Re: isnan function conflicts with C++ standard library declarations

2019-08-28 Thread Martin Storsjö
Hi Bruno, On Wed, 28 Aug 2019, Bruno Haible wrote: Hi Martin, Well in addition to macOS, I can also still reproduce the issue on Linux (Ubuntu 18.04, with its default GCC 7) as well, so maybe it's an issue with newer C++ standard headers, regardless of platform? Indeed. I can reproduce it w

Re: FreeBSD: Warnings about c-ctype macros used but marked unused

2019-08-28 Thread Tim Rühsen
Hi Bruno, On 28.08.19 17:28, Bruno Haible wrote: >> The option -Wused-but-marked-unused is indirectly activated by >> -Weverything > > -Weverything is not something we can support in gnulib. For the > meaning of this option, see > https://quuxplusone.github.io/blog/2018/12/06/dont-use-weverything

Re: isnan function conflicts with C++ standard library declarations

2019-08-28 Thread Bruno Haible
Hi Martin, > Well in addition to macOS, I can also still reproduce the issue on Linux > (Ubuntu 18.04, with its default GCC 7) as well, so maybe it's an issue > with newer C++ standard headers, regardless of platform? Indeed. I can reproduce it with GCC >= 6. And since clang sometimes uses the

Re: FreeBSD: Warnings about c-ctype macros used but marked unused

2019-08-28 Thread Bruno Haible
Hi Tim, > FreeBSD clang version 6.0.0 (tags/RELEASE_600/final 326565) (based on > LLVM 6.0.0) OK. > The option -Wused-but-marked-unused is indirectly activated by > -Weverything -Weverything is not something we can support in gnulib. For the meaning of this option, see https://quuxplusone.githu

Re: FreeBSD: Warnings about c-ctype macros used but marked unused

2019-08-28 Thread Tim Rühsen
Hi Bruno, On 8/28/19 4:09 PM, Bruno Haible wrote: > Hi Tim, > >> Compiling on FreeBSD 12 gives a warning per use of c_ macros, for example >> >> http_parse.c:187:10: warning: 'c_isblank' was marked unused but was used >> [-Wused-but-marked-unused] >> while (c_isblank(*s)) s++; >>

Re: FreeBSD: Warnings about c-ctype macros used but marked unused

2019-08-28 Thread Bruno Haible
Hi Tim, > Compiling on FreeBSD 12 gives a warning per use of c_ macros, for example > > http_parse.c:187:10: warning: 'c_isblank' was marked unused but was used > [-Wused-but-marked-unused] > while (c_isblank(*s)) s++; > > > This is true also for c_isdigit, c_isspace, etc. A bi

FreeBSD: Warnings about c-ctype macros used but marked unused

2019-08-28 Thread Tim Rühsen
Compiling on FreeBSD 12 gives a warning per use of c_ macros, for example http_parse.c:187:10: warning: 'c_isblank' was marked unused but was used [-Wused-but-marked-unused] while (c_isblank(*s)) s++; This is true also for c_isdigit, c_isspace, etc. Is that expected behavior and

Re: isnan function conflicts with C++ standard library declarations

2019-08-28 Thread Martin Storsjö
Hi, On Wed, 28 Aug 2019, Bruno Haible wrote: Hi, Martin Storsjö wrote: When the isnan function is enabled in gnulib, the added bits in math.h break if included in C++ translation units. A minimal reproducion example is available at https://martin.st/temp/gnulib-isnan-repro-0.0.0.tar.gz (prec

Re: isnan function conflicts with C++ standard library declarations

2019-08-28 Thread Bruno Haible
Hi, Martin Storsjö wrote: > When the isnan function is enabled in gnulib, the added bits in math.h > break if included in C++ translation units. > > A minimal reproducion example is available at > https://martin.st/temp/gnulib-isnan-repro-0.0.0.tar.gz (preconfigured and > directly buildable) a