Re: test-striconveh fail to build without libiconv

2019-07-08 Thread Bruno Haible
Hi Tom, > In 8c96eb80bd calls to iconv functions were added outside the HAVE_ICONV > block. > > test-striconveh.c will fail to build if iconv is unavailable: > test-striconveh.c: In function 'main': > test-striconveh.c:1113:7: error: 'cd_ascii_to_88591' undeclared (first > use in this function)

test-striconveh fail to build without libiconv

2019-07-08 Thread Tom G. Christensen
Hello, In 8c96eb80bd calls to iconv functions were added outside the HAVE_ICONV block. test-striconveh.c will fail to build if iconv is unavailable: test-striconveh.c: In function 'main': test-striconveh.c:1113:7: error: 'cd_ascii_to_88591' undeclared (first use in this function) if (cd_a

Re: Remove support for old Solaris threads

2019-07-08 Thread Bruno Haible
Hi Tom, > the gnulib POSIX thread support has been unbuildable on Solaris < 7. > > Just to see what state it's in on Solaris 2.6 I changed the witness back > to pthread_cancel ... We just this week changed the documentation to state that Solaris < 9 is unsupported. [1] Support by Oracle for So

Re: Remove support for old Solaris threads

2019-07-08 Thread Paul Eggert
Tom G. Christensen wrote: Do note though that since you changed the witness symbol in 0f336e1192 the gnulib POSIX thread support has been unbuildable on Solaris < 7. Although it's fine if Bruno fixes that, it's not necessary as Sun stopped supporting Solaris 6 long ago. Generally speaking we

Re: Remove support for old Solaris threads

2019-07-08 Thread Tom G. Christensen
On 06/07/19 03:38, Bruno Haible wrote: The old Solaris threads facility was needed for portability to the ancient Solaris 2.4. Solaris >= 2.5.1 has POSIX threads. Do note though that since you changed the witness symbol in 0f336e1192 the gnulib POSIX thread support has been unbuildable on Sola

Re: Visibility of gnulib's symbols

2019-07-08 Thread Paul Eggert
Marc Nieper-Wißkirchen wrote: What is the canonical way to solve this? Is there an easy way to add $(CFLAGS_VISIBLITY) to the CFLAGs when gnulib is compiled? Or should I try something different? It's hard to say without seeing what you've got. You misspelled CFLAG_VISIBILITY in your email, whi

Visibility of gnulib's symbols

2019-07-08 Thread Marc Nieper-Wißkirchen
Dear all, I'm working on a shared library, for which implementation I make use of gnulib modules. I followed the instructions for the lib-symbol-visibility module (see here: https://www.gnu.org/software/gnulib/manual/html_node/Exported-Symbols-of-Shared-Libraries.html) to make only the documented