Re: [PATCH] areadlink-with-size: guess a buffer size with 0 size

2019-07-06 Thread Paul Eggert
Pádraig Brady wrote: Your patch has the advantage of allocating the exact right sized buffer in the usual case, but the disadvantage of CPU overhead in string length determination, and some extra code complexity in the separate small buffer handling. I think the code complexity is worth it, to

[PATCH] areadlink-with-size: guess a buffer size with 0 size

2019-07-06 Thread Pádraig Brady
On 06/07/19 00:53, Paul Eggert wrote: > Pádraig Brady wrote: >> It would be nice to have areadlink_with_size treat 0 as auto select some >> lower bound. > > Yes, that sounds good. However, I didn't see why that would entail changing > SYMLINK_MAX from 1024 to 1023, or why the patch would affect

[PATCH] Replace manually crafted hex regexes with [:xdigit:]

2019-07-06 Thread Paul Eggert
From: Konstantin Kharlamov * build-aux/gitlog-to-changelog (parse_amend_file) (git_dir_option): Replace various combinations of [0-9a-fA-F] with [[:xdigit:]]. This patch is backported from Emacs (Bug#36167). --- ChangeLog | 8 build-aux/gitlog-to-changelog | 6 +++---

Re: dropping some old platforms from the doc

2019-07-06 Thread Bruno Haible
Paul Eggert wrote: > Thanks, removing that old cruft looks good to me too. Done. Likewise for the mentions of BSDI, BSD/OS, and Tandem/NSK. Also fixed a doc mistake: 2019-07-06 Bruno Haible error: Fix documentation. * doc/glibc-functions/error_at_line.texi: Document what th