Re: [PATCH] ISO C 11 threads implementation

2019-07-03 Thread Paul Eggert
Bruno Haible wrote: I can work on that, if you have no objections. Sounds good, and thanks for looking into that.

Re: argmatch.h: new "_" definition may conflict with that of callers

2019-07-03 Thread Bruno Haible
Akim Demaille wrote: > * lib/argmatch.h (N_, _): Don't define. > Use gettext instead. Note: That's not OK to do for all code in gnulib - since code that is compiled into shared libraries will most often want to do #define _(msg) dcgettext (SOME_DOMAIN, msg) But argmatch is unlikely to b

Re: getaddrinfo tests: fix test failure on MSVC

2019-07-03 Thread Bruno Haible
Hi Gisle, > I found the same problem with test-select-fd.c: > > --- a/tests/test-select-fd.c 2019-01-02 12:05:09 > +++ b/tests/test-select-fd.c 2019-07-03 06:48:11 > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > > int > main (int argc, char *argv[]) > @@ -44,6 +4

mbrtowc: fix invalid use of mbtowc() on MSVC

2019-07-03 Thread Bruno Haible
On MSVC, I am seeing test failures: FAIL: test-mbrtowc2.sh == C:\testdir-posix-msvc\gltests\test-mbrtowc.c:205: assertion 'ret == 1' failed FAIL test-mbrtowc2.sh (exit status: 127) FAIL: test-mbsnrtowcs2.sh = C:\testdir-posix-msvc\gltests\test-mbsnrto

Re: getaddrinfo tests: fix test failure on MSVC

2019-07-03 Thread Gisle Vanem
Bruno Haible wrote: On native Windows with MSVC, I observe this test failure: FAIL: test-getaddrinfo == FAIL test-getaddrinfo.exe (exit status: 4) The cause is a missing call to WSAStartup(). This patch fixes it. I found the same problem with test-select-fd.c: --- a/tes