Re: bug#36370: 27.0.50; XFIXNAT called on negative numbers

2019-06-27 Thread Pip Cet
On Thu, Jun 27, 2019 at 9:13 PM Paul Eggert wrote: > On 6/27/19 12:56 PM, Pip Cet wrote: > > The eassume tells GCC i is nonnegative, since (!(i >= 0) == !(i >= 0)) > > is indeed a constant. > > Ah! Thanks, I didn't catch that subtle point. Would the attached patch > to verify.h address that proble

Re: bug#36370: 27.0.50; XFIXNAT called on negative numbers

2019-06-27 Thread Paul Eggert
On 6/27/19 4:45 PM, Bruno Haible wrote: Can you please show an example code on which the change makes a difference? Not easily, I'm afraid. I grabbed the latest Emacs master , ran './configure; make CFLAGS=-O2', edited the emacs lib/verify.h, and ra

Re: bug#36370: 27.0.50; XFIXNAT called on negative numbers

2019-06-27 Thread Bruno Haible
Hi Paul, > I'll CC: this to bug-gnulib since it's a Gnulib issue. I have not > installed this patch into Gnulib on savannah. Can you please show an example code on which the change makes a difference? I used this test program foo.c =

Re: bug#36370: 27.0.50; XFIXNAT called on negative numbers

2019-06-27 Thread Paul Eggert
On 6/27/19 12:56 PM, Pip Cet wrote: The eassume tells GCC i is nonnegative, since (!(i >= 0) == !(i >= 0)) is indeed a constant. Ah! Thanks, I didn't catch that subtle point. Would the attached patch to verify.h address that problem? This patch is for Gnulib, but would propagate into Emacs.