Re: VLA and alloca

2019-02-02 Thread Paul Eggert
Tim Rühsen wrote: Just reading this CVE [1] from a week ago, makes me want to disable all large allocations on the stack. Yes please. Any chance to remove it from gettext.h ? #if _LIBGETTEXT_HAVE_VARIABLE_SIZE_ARRAYS char msg_ctxt_id[msgctxt_len + msgid_len]; #else It's already removed fr

Re: VLA and alloca

2019-02-02 Thread Paul Eggert
Bruno Haible wrote: How about making use of this GNULIB_NO_VLA macro in all places that assume VLA syntax? That's OK for allocating VLAs, but it's too broad for vla.h since vla.h does not allocate VLAs and its uses of variable-length arrays do not have the security or performance issues that

[PATCH] dtoastr,ftoastr,ldtoastr: port to c-strtod changes

2019-02-02 Thread Paul Eggert
Decouple these modules from c-strtod. Nowadays it’s reasonable to assume the C99 signatures for strtod and strtold. Programs that require stricter adherence to C99 should also use the strtod and strtold modules as needed, and we no longer need the HAVE_C99_STRTOLD macro. * NEWS: Mention this. * l

Re: [PATCH] tests: Fix some missing includes

2019-02-02 Thread Bruno Haible
Hi Colin, > Without this, we get "error: 'CHAR_BIT' undeclared". > > * tests/test-array_map.c: Include . > * tests/test-hash_map.c: Likewise. > * tests/test-linkedhash_map.c: Likewise. Thanks. Applied. Bruno

[PATCH] tests: Fix some missing includes

2019-02-02 Thread Colin Watson
Without this, we get "error: 'CHAR_BIT' undeclared". * tests/test-array_map.c: Include . * tests/test-hash_map.c: Likewise. * tests/test-linkedhash_map.c: Likewise. --- tests/test-array_map.c | 1 + tests/test-hash_map.c | 1 + tests/test-linkedhash_map.c | 1 + 3 files changed, 3 inse