Re: cmake support

2019-01-05 Thread Bruno Haible
Andrew Pennebaker wrote: > MSVC integration will become more interesting The usual way to do MSVC builds of packages that use Autotools is to use wrapper scripts 'ar-lib' and 'compile' that provide a Unix-y interface to the MSVC compilers. See https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=b

Re: Tag v0.2?

2019-01-05 Thread Paul Eggert
Andrew Pennebaker wrote: Looks like 5 years have passed since a release. Could we get a new tag pushed, so that developers can pin to a relatively recent edition of Gnulib, without accidentally receiving breaking changes? I thought tags were for actual releases, which we've sort of dropped as n

Re: bug#33965: handling of closed file descriptors

2019-01-05 Thread Paul Eggert
Bruno Haible wrote: The feature is not portable to POSIX platforms. Besides, I doubt whether anybody is using the feature anyway. OK, if you question the "feature" as a whole, Sorry, I was referring only to the never-used feature of diffutils, where "-" in a command-line argument stands for

Tag v0.2?

2019-01-05 Thread Andrew Pennebaker
Looks like 5 years have passed since a release. Could we get a new tag pushed, so that developers can pin to a relatively recent edition of Gnulib, without accidentally receiving breaking changes? -- Cheers, Andrew

Re: cmake support

2019-01-05 Thread Andrew Pennebaker
Ach, I've made a career out of not having to know autotools! ./configure && make && [sudo] make install were black boxes as far as I was concerned. So be it, I'll spend some time reading up this weekend and see how far I get. MSVC integration will become more interesting, but I suppose I can disab

Re: argp: pass NULL as msgid to dgettext without checks

2019-01-05 Thread He X
prove that man-db and tar works(which used to segfault). hope builtin argp could be updated soon. i will report if i met another NULL pointer case. thanks for your work! :) Bruno Haible 于2019年1月6日周日 上午12:17写道: > He X wrote: > > > The msgid argument is a null-terminated string. > > > > problem i

Re: cmake support

2019-01-05 Thread Kamil Dudka
On Saturday, January 5, 2019 6:53:06 PM CET Bruno Haible wrote: > Hi, > > Andrew Pennebaker wrote: > > Could we improve how gnulib integrates with downstream projects, to make > > it > > easier to work with different build tools? In particular, would be helpful > > for gnulib to easily work with c

Re: cmake support

2019-01-05 Thread Bruno Haible
Hi, Andrew Pennebaker wrote: > Could we improve how gnulib integrates with downstream projects, to make it > easier to work with different build tools? In particular, would be helpful > for gnulib to easily work with cmake projects. > > In my case, I have an application that needs openat(), and I

Re: cmake support

2019-01-05 Thread Paul Eggert
Andrew Pennebaker wrote: Could we improve how gnulib integrates with downstream projects, to make it easier to work with different build tools? In particular, would be helpful for gnulib to easily work with cmake projects. It would also be helpful for Gnulib to work better with GNU Make, while

cmake support

2019-01-05 Thread Andrew Pennebaker
Could we improve how gnulib integrates with downstream projects, to make it easier to work with different build tools? In particular, would be helpful for gnulib to easily work with cmake projects. In my case, I have an application that needs openat(), and I already have a complex cmake configurat

Re: argp: pass NULL as msgid to dgettext without checks

2019-01-05 Thread Bruno Haible
He X wrote: > > The msgid argument is a null-terminated string. > > problem is that msgid is a empty pointer, not a pointer to a > NULL-terminated string. > > full backtrace: > > ``` > #0 0x77fab65d in strcmp (l=0x0, r=0x77eff7df "Packaged by > %s\n") at src/string/strcmp.c:5 > #1

Re: test case build errors

2019-01-05 Thread Tom G. Christensen
On 04/01/19 20:32, Bruno Haible wrote: Fixed as follows. 2019-01-04 Bruno Haible Fix link errors in unit tests. Reported by Tom G. Christensen . * modules/bitset-tests (Makefile.am): Link test-bitset against libintl. * modules/array-map-tests (Makefile.am): Li

Re: argp: pass NULL as msgid to dgettext without checks

2019-01-05 Thread Bruno Haible
Hi, He X wrote on 2018-12-22: > according to > https://www.gnu.org/software/gettext/manual/html_node/Interface-to-gettext.html, > passing NULL to gettext is undefined. Likewise the LI18NUX 2000 specification (p. 39) says "The msgid argument is a null-terminated string." And likewise the LSB 3.

Re: new module suggestion: fprintftime-check

2019-01-05 Thread Florian Weimer
* Bruno Haible: > Florian Weimer wrote: >> The standards do not provide a way to report errors for malformed format >> strings. I think the current behavior is acceptable, all things >> considered. > > OK, then I'm fine with Assaf's approach to create a new, separate function > that does only the

Re: Gnulib breaks CC_FOR_BUILD

2019-01-05 Thread Bruno Haible
Hi, John Darrington wrote on 2018-12-22: > I'm trying to use gnulib in the same project as ax_prog_cc_for_build.m4 > from the autoconf archive[1]. But it seems that they do not play nicely > together. > > Specifically, gnulibs std-gnu11.m4 seems to negate the effect of the former, > resulting in

Re: [Regression/Android] Commit e7fb52b3 causes segfault on 32-bit platforms

2019-01-05 Thread Bruno Haible
Paul Eggert wrote on 2018-12-22: > bore wrote: > > What is causing this is > > int _flags; \ > > int _file; \ > > on 32bit it needs to be > > short _flags; \ > > short _file; \ > > Thanks for the suggestion. Does the attached Gnulib patch fix the problem? I > haven't installed it and can't easi

Re: new module suggestion: fprintftime-check

2019-01-05 Thread Bruno Haible
Florian Weimer wrote: > The standards do not provide a way to report errors for malformed format > strings. I think the current behavior is acceptable, all things > considered. OK, then I'm fine with Assaf's approach to create a new, separate function that does only the syntax checking. Bruno

Re: preferring ptrdiff_t to size_t

2019-01-05 Thread Bruno Haible
Paul Eggert wrote: > Using signed types is better nowadays than using unsigned types, since > many platforms now check for signed integer overflow and this can catch many > bugs, some of them security-relevant, whereas unsigned arithmetic is well > defined to wrap around with no overflow check (

Re: bug#33965: handling of closed file descriptors

2019-01-05 Thread Bruno Haible
[CCing bug-gnulib. This is a followup to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33965 ] Hi Paul, > The feature is not portable to POSIX > platforms. Besides, I doubt whether anybody is using the feature anyway. OK, if you question the "feature" as a whole, then I'd say: * Users don't