Re: timevar: 3/3: use clock_gettime to get wall clock time

Hi Akim, > > I don’t know how 'gettime' compares against 'gethrxtime'. > > gethrxtime is exactly what I need, thanks! It does use gettime as > a fallback, after having tried better (accuracy and monotony) options. Very nice! > Here is my updated proposal. Looks good, except for the mentioned

Re: timevar: 3/3: use clock_gettime to get wall clock time

> Le 12 oct. 2018 à 17:59, Bruno Haible a écrit : > > Hi Akim, > > There are three issues with this patch: > > 1) Portability. As listed in > https://www.gnu.org/software/gnulib/manual/html_node/clock_005fgettime.html > Gnulib provides no replacement for clock_gettime. So, you'll probably ne

bootstrap: fix wget command for po files

I can’t bootstrap bison. I’m surprised this could have worked since the removal of the rsync command. commit 6c3b072e6a48d45455b37420caf14b804cbba23c Author: Akim Demaille Date: Sat Oct 13 07:16:00 2018 +0200 bootstrap: fix wget command for po files. * build-aux/bootstrap (po_dow

Re: timevar: 1/3: expect that getrusage is available

Hi Akim, > > - The code prints the '.wall' values, which are not initialized. But this > >is fixed in part 3/3. > > They are initialized > > static void > set_to_current_time (struct timevar_time_def *now) > { > now->user = 0; > now->sys = 0; > now->wall = 0; > > but yes, they are n

Re: timevar: 1/3: expect that getrusage is available

> Le 12 oct. 2018 à 17:27, Bruno Haible a écrit : > > Hi Akim, > > This patch looks good, except for two things: > - The module description still references m4/timevar.m4, which no longer >exists. Fixed, thanks! > - The code prints the '.wall' values, which are not initialized. But th

Re: bug#6816: df bug on 64-bit Solaris (need to use getextmntent)

David Wood wrote: > >> At this point, me->me_dev contains a wrongly packed (32-bit) device > >> number, which forces the find_mount_point() code path (causing other > >> unpleasantries). The following patch against coreutils v8.5 fixes the > >> problem: This problem description was to the poin

mountlist: Add support for Minix

Assaf Gordon wrote in : > './configure' fails to detect "getmntinfo()" function call: > $ ./configure > checking whether it is possible to resort to fread on /etc/mnttab... no > configure: error: could not determin

Re: timevar: 3/3: use clock_gettime to get wall clock time

Hi Akim, There are three issues with this patch: 1) Portability. As listed in https://www.gnu.org/software/gnulib/manual/html_node/clock_005fgettime.html Gnulib provides no replacement for clock_gettime. So, you'll probably need gettimeofday or module 'gettime' as fallback. For clock_gettime, yo

Re: timevar: 2/3: improve the output format

Hi Akim, > I have used the format you suggested to display the times. Thanks, looks great, and support programs that terminate in < 0.1 seconds. > I’m not sure we should specify the resolution, it kinda of is displayed > by the figures themselves It's good enough like this. The actual resolutio

Re: timevar: 1/3: expect that getrusage is available

Hi Akim, This patch looks good, except for two things: - The module description still references m4/timevar.m4, which no longer exists. - The code prints the '.wall' values, which are not initialized. But this is fixed in part 3/3. Bruno

use AC_CACHE_CHECK where possible

AC_CACHE_CHECK is a nice combination of AC_MSG_CHECKING + AC_CACHE_VAL + AC_MSG_RESULT. Already used more than 500 times in gnulib. Make more use of it. 2018-10-12 Bruno Haible Make better use of Autoconf. * m4/environ.m4: Use AC_CACHE_CHECK where possible. * m4/manywa