Re: [gawk-devel] changing regex lib

2018-08-11 Thread Paul Eggert
Bruno Haible wrote: Therefore I would rewrite the comment /* Convert the byte B to the corresponding wide character. In a unibyte locale, treat B as itself. In a multibyte locale, return WEOF if B is an encoding error. */ to /* Convert the byte B to a value that bounds the iterati

Re: use of __builtin_trap

2018-08-11 Thread Paul Eggert
Bruno Haible wrote: Would it be possible to use abort () instead of __builtin_trap ()? It would, but I'm not sure it'd be a good idea, as assume(X) is not intended to be a safety check: it's intended to be a message from the programmer to static analysis tools such as GCC's optimizer and/or w

Re: [gawk-devel] changing regex lib

2018-08-11 Thread arnold
Paul Eggert wrote: > arn...@skeeve.com wrote: > > I tried out Paul's change and it works for me. > > Thanks for checking. I installed the regcomp.c change into glibc and gnulib > so > we should now have the same source there as we have in Gawk. Thanks Paul! I will likely merge that into the g

use of __builtin_trap

2018-08-11 Thread Bruno Haible
Hi Paul, > # define assume(R) ((R) ? (void) 0 : __builtin_trap ()) Would it be possible to use abort () instead of __builtin_trap ()? __builtin_trap has the drawback that is provides this message: Illegal instruction (core dumped) (at least on x86_64) which points to user/developer to a bug

[PATCH] verify: port 'assume' to traditional tools

2018-08-11 Thread Paul Eggert
* lib/verify.h (assume): Port better to Oracle Studio 12.6 and other tools that use /*NOTREACHED*/ comments. --- ChangeLog| 6 ++ lib/verify.h | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 404af4f13..6418dae91 100644 --- a/ChangeLog +++

Re: Adding strfmon(3) to Gnulib?

2018-08-11 Thread John Zaitseff
Hi, all, I wrote back on 23rd July: > [...] Is it worth adding strfmon(3) and possibly strfmon_l(3) for > those systems that do not have it? I'm thinking primarily > OpenBSD, even in the latest version. This OS does not have > either. and > [...] If the Gnulib maintainers are agreeable, I'll