On 25/06/18 18:20, Bruno Haible wrote:
> Hi Jim,
>
>> diff --git a/lib/acl-internal.h b/lib/acl-internal.h
>> index 6c65e65e5..0669d83c4 100644
>> --- a/lib/acl-internal.h
>> +++ b/lib/acl-internal.h
>> @@ -293,10 +293,6 @@ struct permission_context {
>>
>> int get_permissions (const char *, int,
On 25/06/18 17:37, Bruno Haible wrote:
> Pádraig Brady wrote:
>> Your test failure was:
>> FAIL: test-rwlock1
>> ==
>> Unexpected outcome 3
>> FAIL test-rwlock1 (exit status: 134)
>> which is due to glthread_create() failing.
>> CC'ing gnulib.
>
> The patch below fixes it.
On 06/25/2018 06:20 PM, Bruno Haible wrote:
One version of GCC wants the 'const' attribute, another one complains
about it...
Isn't it time to disable either -Werror or -Wattribute?
I've found -Wattribute and -Werror to be useful with recent GCC.
However, the cost of pacifying older GCC's war
Hi Jim,
> diff --git a/lib/acl-internal.h b/lib/acl-internal.h
> index 6c65e65e5..0669d83c4 100644
> --- a/lib/acl-internal.h
> +++ b/lib/acl-internal.h
> @@ -293,10 +293,6 @@ struct permission_context {
>
> int get_permissions (const char *, int, mode_t, struct permission_context *);
> int set
Pádraig Brady wrote:
> Your test failure was:
> FAIL: test-rwlock1
> ==
> Unexpected outcome 3
> FAIL test-rwlock1 (exit status: 134)
> which is due to glthread_create() failing.
> CC'ing gnulib.
The patch below fixes it.
The issue is caused by three factors:
1) The gnu
On Mon, Jun 25, 2018 at 12:07 PM, Bruno Haible wrote:
...
> OK, done as follows:
>
> 2018-06-25 Bruno Haible
>
> manywarnings: Don't enable -Wjump-misses-init warnings by default.
> * build-aux/gcc-warning.spec: Add -Wjump-misses-init.
> * m4/manywarnings.m4 (gl_MANYWARN
Oops, I committed this:
> @@ -80,7 +84,7 @@ test_digest_on_files (int (*streamfunc) (FILE *, void *),
>{
>case 0: expected = expected_for_empty_file; break;
>case 1: case 2: expected = expected_for_small_file; break;
> - case 3: expected
Paul Eggert wrote:
> > - /* Avoid calling both strcpy and strlen. */
> > - for (int i = 0; (salg.salg_name[i] = alg[i]); i++)
> > + /* Copy alg into salg.salg_name, without calling strcpy nor strlen. */
> > + for (size_t i = 0; (salg.salg_name[i] = alg[i]) != '\0'; i++)
> If you don't like i
Paul Eggert wrote:
> the warning is not emitted if the program simply does this instead:
>
> int x; x = 10;
>
Indeed: While
===
extern void bar (int);
int foo (int a)
{
if (a == 1) goto one;
int b = 4;
bar (b);
one:
return a;
}
On 06/24/2018 03:58 PM, Pádraig Brady wrote:
So it doesn't look like this is required.
That's right. When I wrote this code originally, I verified this by
looking at the kernel source, for what that's worth.
On 06/24/2018 03:28 PM, Bruno Haible wrote:
- /* Avoid calling both strcpy and strlen. */
- for (int i = 0; (salg.salg_name[i] = alg[i]); i++)
+ /* Copy alg into salg.salg_name, without calling strcpy nor strlen. */
+ for (size_t i = 0; (salg.salg_name[i] = alg[i]) != '\0'; i++)
I prefer
> From: "Pádraig Brady"
> To: "DATACOM"
> Cc: "Jim Meyering" , "bug-gnulib"
> Sent: Monday, June 25, 2018 1:58:15 PM
> Subject: Re: [PATCH] lib/acl-internal.h: fix build failure with
> -Werror=attributes
> Sorry we didn't get to it.
> Jim has handled this independently just now
Great! Thanks.
Sorry we didn't get to it.
Jim has handled this independently just now
On 25/06/18 03:09, Erik Auerswald wrote:
> Hi,
>
> On Sun, Jun 24, 2018 at 11:43:55PM -0700, Pádraig Brady wrote:
>> We plan to release coreutils-8.30 in the coming week
>> so any testing you can do on various different systems between now and then
>> would be most welcome.
>
> I have tested on a
FYI, I saw another coreutils build failure when configured with
--enable-gcc-warnings and this addresses it:
>From ed78f0e059003680af6476989c39c9ba18ae3fd0 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 25 Jun 2018 08:28:12 -0700
Subject: [PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST
Bruno Haible wrote:
Can someone answer this?
I expect the warning is there because of style reasons, not correctness reasons.
That is, although it's natural when seeing this line:
int x = 10;
to assume that X must always be initialized, this assumption is incorrect if a
goto jumps over
On 06/25/2018 02:00 AM, Bruno Haible wrote:
> Hi Jim, Paul,
>
>> parse-datetime.y: In function 'parse_datetime2':
>> parse-datetime.y:1791:19: error: jump skips variable initialization \
>> [-Werror=jump-misses-init]
>
> First this occurred in af_alg.c with pretty standard Linux kernel style
>
17 matches
Mail list logo
