Re: gnulib getloadavg: incorrect .Po included in root Makefile.in

2018-06-21 Thread Bruno Haible
Paul Smith wrote: > However, for lib/getloadavg.c and ONLY for that lib/*.c file, I ALSO > get duplicate rules in my root Makefile.in Does it cause an actual problem, or does it only "feel" wrong? Do you use Automake's subdir-object option? Bruno

Re: Another patch (warning)

2018-06-21 Thread Paul Eggert
On 06/20/2018 12:34 PM, Bruce Korb wrote: random_r.c:289:13: warning: cast from 'char *' to 'int32_t *' (aka 'int *') increases required alignment from 1 to 4 Thanks for reporting the warning. As Eric mentioned, this is a bug in random_r.c that can cause crashes. I reproduced one such crash an

Re: Another patch (warning)

2018-06-21 Thread Bruce Korb
Hi Eric, On Thu, Jun 21, 2018 at 5:43 AM Eric Blake wrote: > > On 06/20/2018 02:34 PM, Bruce Korb wrote: > > diff --git a/lib/random_r.c b/lib/random_r.c > > index 697ca5f..cd2537a 100644 > > --- a/lib/random_r.c > > +++ b/lib/random_r.c > > @@ -286,7 +286,7 @@ __initstate_r (unsigned int seed, ch

Re: Another patch (warning)

2018-06-21 Thread Eric Blake
On 06/20/2018 02:34 PM, Bruce Korb wrote: diff --git a/lib/random_r.c b/lib/random_r.c index 697ca5f..cd2537a 100644 --- a/lib/random_r.c +++ b/lib/random_r.c @@ -286,7 +286,7 @@ __initstate_r (unsigned int seed, char *arg_state, size_t n, buf->rand_type = type; buf->rand_sep = separation;