Re: [PATCH] bootstrap: allow non-submodule control of gnulib

2018-05-27 Thread Colin Watson
On Sun, May 27, 2018 at 10:17:40PM +0200, Bruno Haible wrote: > I've pushed both patches in your name now. > > Had to adapt them a bit because the file 'build-aux/bootstrap' had been > reindented meanwhile. Thanks! -- Colin Watson [cjwat...@debian.org]

Re: [PATCH] bootstrap: allow non-submodule control of gnulib

2018-05-27 Thread Bruno Haible
Colin Watson wrote: > In the following message there's an > additional commit that adds what I think is reasonable documentation of > this; comments welcome. This is intended to be applied on top of my > previous patch in > https://lists.gnu.org/archive/html/bug-gnulib/2018-04/msg00029.html, > whi

[PATCH 2/2] bootstrap: document source fetching in --help

2018-05-27 Thread Colin Watson
There are many possibilities for how Gnulib sources are fetched, and they're rather hard to figure out without reading the code. * build-aux/bootstrap (usage): Document how Gnulib sources are fetched. Signed-off-by: Colin Watson --- build-aux/bootstrap | 35 ++-

Re: [PATCH] bootstrap: allow non-submodule control of gnulib

2018-05-27 Thread Colin Watson
On Mon, Apr 09, 2018 at 01:12:14PM +0200, Bruno Haible wrote: > What I'm saying is that code changes that offer more choice to the user > should be accompanied with documentation changes, so that the user is > aware of the choices that you offer them. > > Guessing what are the possible choices, by

Re: gcc/g++-warning.spec: remove -Wswitch-enum?

2018-05-27 Thread Reuben Thomas
On 27 May 2018 at 09:13, Paul Eggert wrote: > For what it's worth, Emacs configure.ac disables -Wswitch-default (too > many warnings) and -Wswitch (since -Wall implies -Wswitch, and the Emacs > folks want to shorten the command line). Coreutils configure.ac disables > both -Wswitch-enum (unneces

Re: gcc/g++-warning.spec: remove -Wswitch-enum?

2018-05-27 Thread Paul Eggert
For what it's worth, Emacs configure.ac disables -Wswitch-default (too many warnings) and -Wswitch (since -Wall implies -Wswitch, and the Emacs folks want to shorten the command line). Coreutils configure.ac disables both -Wswitch-enum (unnecessary, since Gnulib also disables it) and -Wswitch-d

gcc/g++-warning.spec: remove -Wswitch-enum?

2018-05-27 Thread Reuben Thomas
The default warnings set contains -Wswitch-default, which gives a warning if a switch lacks a default case. Therefore, -Wswitch is useless, because (assuming authors fix all warnings) there will already be a default label. In order to catch missing enumeration cases, -Wswitch-enum is needed. (If o