Re: test-poll failing on FreeBSD 10/11

2018-05-14 Thread Pádraig Brady
On 08/05/18 09:40, Daniel P. Berrangé wrote: > Libvirt CI recently started running "make check" on our FreeBSD 10 & 11 > hosts, and we see frequent failure of the test-poll unit test in gnulib > IIUC, gnulib is not actually building a replacement poll() function > on FreeBSD, it is merely running

Re: Parallel building of uni*/ dirs

2018-05-14 Thread Bruno Haible
Hi Tim, > This loop is in gnulib code, lib/Makefile.am (L263, ff. here). I don't see such loops in a typical Makefile.am generated by gnulib-tool. Can you attach the Makefile.am and Makefile.in, please? Bruno

Re: Parallel building of uni*/ dirs

2018-05-14 Thread Tim Rühsen
On 05/14/2018 10:24 AM, Bruno Haible wrote: > Tim Rühsen wrote: >> I am not an expert here > Neither am I. This would better be a topic for the help-make or bug-make > mailing > list, I guess. Bruno, why do you think this is a make issue ? This loop is in gnulib code, lib/Makefile.am (L263, ff.

Re: bug#31439: [PATCH] fts: avoid a memory leak edge case

2018-05-14 Thread Pádraig Brady
On 14/05/18 01:28, Bruno Haible wrote: > Kamil Dudka wrote: >> Why are you removing fflush (stdout) from the test without any explanation? > > Yes, fflush(stdout) statements are extremely important if you want to > understand/debug test failures on native Windows. Oops, I wasn't aware of windows

Re: bug#31439: [PATCH] fts: avoid a memory leak edge case

2018-05-14 Thread Bruno Haible
Kamil Dudka wrote: > Why are you removing fflush (stdout) from the test without any explanation? Yes, fflush(stdout) statements are extremely important if you want to understand/debug test failures on native Windows. Bruno

Re: Parallel building of uni*/ dirs

2018-05-14 Thread Bruno Haible
Tim Rühsen wrote: > I am not an expert here Neither am I. This would better be a topic for the help-make or bug-make mailing list, I guess. Bruno

Re: bug#31439: [PATCH] fts: avoid a memory leak edge case

2018-05-14 Thread Kamil Dudka
On Monday, May 14, 2018 3:51:02 AM CEST Pádraig Brady wrote: > @@ -122,9 +139,10 @@ main (void) > perror_exit (base, 6); >while ((e = fts_read (ftsp))) > needles_seen += strcmp (e->fts_name, "needle") == 0; > - fflush (stdout); >if (errno) > perror_exit ("fts_read", 7); > +