Re: [PATCH] wcwidth: check a macro version of wcwidth () as well

2017-10-09 Thread Bruno Haible
Eric Blake wrote: > On 10/07/2017 02:23 AM, Bruno Haible wrote: > > Thanks, I applied your patch, with the additional optimizations (below): > > > > > - Simplify 'test EXPR1 || test EXPR2' to 'test EXPR1 -o EXPR2'. > > No, that is a pessimization. POSIX explicitly states that use of -a or > -o

Re: [PATCH] wcwidth: check a macro version of wcwidth () as well

2017-10-09 Thread Eric Blake
On 10/07/2017 02:23 AM, Bruno Haible wrote: > Thanks, I applied your patch, with the additional optimizations (below): > > - Simplify 'test EXPR1 || test EXPR2' to 'test EXPR1 -o EXPR2'. No, that is a pessimization. POSIX explicitly states that use of -a or -o with test is prone to obscure brea

Re: Build error due to missing locale_t on IBM z/OS

2017-10-09 Thread Daniel Richard G.
On Mon, 2017 Oct 9 18:11+0200, Bruno Haible wrote: > > Thanks, I understand. However, I don't think it is adequate to put > this into a specific package (gawk) or gnulib; rather, I like the way > Autoconf-generated configure files obey the environment variables. Environment variables are still re

Re: Build error due to missing locale_t on IBM z/OS

2017-10-09 Thread Bruno Haible
Hi Daniel, > > 1) What is 'xlc-wrap', compared to 'xlc'? (I'd like to know if > >something is missing in Autoconf or gnulib-common.m4.) > > xlc-wrap is my own script. It is quite simple: > > #!/bin/sh > exec xlc -qnosearch "$@" -qsearch=/usr/include > > It is used to work around a n

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-10-09 Thread Bruno Haible
Daniel P. Berrange wrote: > Tested-by: Daniel P. Berrange > > > Confirmed it fixes the failure on Fedora 28, and does not cause a regression > on Fedora 26 with older glibc. Thanks. Pushing it: 2017-10-09 Bruno Haible getopt-posix: Fix build failure when using ac_cv_header_getopt_

Re: [libvirt] gnulib tests in libvirt broken by newer glibc 2.26

2017-10-09 Thread Daniel P. Berrange
On Fri, Oct 06, 2017 at 07:59:13PM +0200, Bruno Haible wrote: > Daniel P. Berrange wrote: > > From my own F28 rawhide install with glibc-2.26.90-16.fc28.x86_64 > > > > > > > > 1) The output of > > > $ nm test-getopt-posix | grep getopt > > > > $ nm test-getopt-posix | grep getopt > >