Re: [PATCH] maint: set LANG=C instead of LC_ALL=C

2017-08-10 Thread Eric Blake
On 08/10/2017 05:37 PM, Bruno Haible wrote: >> You still want a sane fallback for all the categories that you are not >> explicitly setting. It's harder to type: >> >> LANG=C LC_CTYPE=C.UTF-8 env -u LC_ALL foo > > or: > LANG=C LC_CTYPE=C.UTF-8 LC_ALL= foo If setting LC_ALL to empty forces fall

Re: [PATCH] maint: set LANG=C instead of LC_ALL=C

2017-08-10 Thread Bruno Haible
> You still want a sane fallback for all the categories that you are not > explicitly setting. It's harder to type: > > LANG=C LC_CTYPE=C.UTF-8 env -u LC_ALL foo or: LANG=C LC_CTYPE=C.UTF-8 LC_ALL= foo > than it is to type > > LC_CTYPE=C.UTF-8 foo > > where we know that LANG=C is already se

Re: Feature Request: Implement glibc reallocarray() function

2017-08-10 Thread Paul Eggert
Darshit Shah wrote: This page was written in 2015. However, on netbsd.org, NetBSD 7.1 is the current latest release. Also, when exactly do we consider reallocarray being available in NetBSD since the page only states that the redesigned version, reallocarr (note the missing 'ay') is available f

Re: [PATCH] maint: set LANG=C instead of LC_ALL=C

2017-08-10 Thread Eric Blake
On 08/10/2017 11:36 AM, Daniel P. Berrange wrote: > The maint.mk file currently sets LC_ALL=C so that build rules get a > predictable locale, independant of the user's environment settings. s/independant/independent/ > > It is sometimes neccesssary to override the locale when running s/neccesss

Re: [PATCH] maint: set LANG=C instead of LC_ALL=C

2017-08-10 Thread Eric Blake
On 08/10/2017 12:59 PM, Paul Eggert wrote: > Daniel P. Berrange wrote: >> It is sometimes neccesssary to override the locale when running >> build commands from make rules, but as maint.mk set LC_ALL, it >> is impossible to selectively override rules e.g. LC_CTYPE=C.UTF-8 >> will have no effect if

Re: [PATCH] maint: set LANG=C instead of LC_ALL=C

2017-08-10 Thread Paul Eggert
Daniel P. Berrange wrote: It is sometimes neccesssary to override the locale when running build commands from make rules, but as maint.mk set LC_ALL, it is impossible to selectively override rules e.g. LC_CTYPE=C.UTF-8 will have no effect if LC_ALL is already set. Why not unset LC_ALL?

[PATCH] maint: set LANG=C instead of LC_ALL=C

2017-08-10 Thread Daniel P. Berrange
The maint.mk file currently sets LC_ALL=C so that build rules get a predictable locale, independant of the user's environment settings. It is sometimes neccesssary to override the locale when running build commands from make rules, but as maint.mk set LC_ALL, it is impossible to selectively overri

Re: Feature Request: Implement glibc reallocarray() function

2017-08-10 Thread Darshit Shah
* Paul Eggert [170810 16:51]: Thanks, a few more things (hopefully we're getting to the end now). "missing on many platforms" lists reallocarray as missing in FreeBSD 11.1, NetBSD 8.0, and OpenBSD 5.6. But it's not missing in those versions: those are the versions it was first introduced.

Re: Feature Request: Implement glibc reallocarray() function

2017-08-10 Thread Paul Eggert
Thanks, a few more things (hopefully we're getting to the end now). "missing on many platforms" lists reallocarray as missing in FreeBSD 11.1, NetBSD 8.0, and OpenBSD 5.6. But it's not missing in those versions: those are the versions it was first introduced. Please fit ChangeLog entries to 7

Re: [PATCH 4/6] fts: cache dirent_inode_sort_may_be_useful too

2017-08-10 Thread Paul Eggert
Tom G. Christensen wrote: This broke the build on CentOS 6 since it has glibc 2.12 which is from before the introduction of the internal __fsword_t type. Thanks for reporting that. I reproduced the problem on a nearby old server and fixed it by installing the attached patch. >From 356f06d605b2