> > + int user_key =
> > +((opt & (1 << (USER_BITS - 1))) ? ~USER_MASK : 0) | (opt &
> > USER_MASK);
>
> Yes, thanks, that's simpler than what is there now, and (in theory at least)
> is
> more portable.
OK, pushed.
Bruno Haible wrote:
* When I edit a file in the testdir using 'vi', the change gets propagated
back to the gnulib checkout. But it does not do so with 'emacs' or 'kate'
as editor.
It works for me with Emacs, possibly because I have had the following in my
~/.emacs for many years:
Bruno Haible wrote:
Whereas here, memory leaks don't depend on gcc options, nor on the platform.
I was worried more about something like this: a test for feature X has a subtest
for feature Y that fails, then the feature-X test calls fclose but fclose
doesn't free the storage because of the f
Jim Meyering wrote:
Eventually, we should consider putting it [FALLTHROUGH] somewhere common and
perhaps
renaming it to have the GL_ prefix.
The former sounds good. The latter, I'm more dubious about, as the macro is
called FALLTHROUGH in bleeding-edge Emacs source code (admittedly thanks to
Bruno Haible wrote:
+ int user_key =
+((opt & (1 << (USER_BITS - 1))) ? ~USER_MASK : 0) | (opt & USER_MASK);
Yes, thanks, that's simpler than what is there now, and (in theory at least) is
more portable.
> The intended operation (in terms of bits) is:
>
> z...abcdefghijklmnopqrstuvwx
> ->abcdefghijklmnopqrstuvwx
Correction: It is like this:
abcdefghijklmnopqrstuvwx
->abcdefghijklmnopqrstuvwx
Bruno
On Sat, May 20, 2017 at 3:15 AM, Bruno Haible wrote:
> Jim Meyering wrote:
>> * tests/test-tsearch.c (mangle_tree): Likewise. Also include
>> tests/macros.h for the definition.
>> * tests/test-argp.c (group1_parser): Likewise.
>
> The module descriptions need to be adjusted accordingly:
>
>
> 201
Paul Eggert wrote:
> > What is the best practice here? Should -fsanitize=address only be activated
> > after configure has run? Or should all configure run tests be changed so
> > that they
> > free all allocated memory?
>
> ... This is partly why we advise people not to run 'configure'
> with -
Hi Paul,
> > The message "Saw a #BR!" is a bit cryptic
> > Does someone understand this argp-help.c code?
>
> I didn't, but after looking at the code for a bit I see a problem that
> could explain the symptoms you observe. hol_append subtracts pointers
> into different arrays, which has undefin
gnulib-tool has done hard-linking for testdirs since the beginning, but it has
more drawbacks than advantages:
* When I am building a testdir and doing unrelated changes in my gnulib
checkout at the same time, especially on the .m4 files, it will trigger
a reconfiguration of the testdir,
Jim Meyering wrote:
> * tests/test-tsearch.c (mangle_tree): Likewise. Also include
> tests/macros.h for the definition.
> * tests/test-argp.c (group1_parser): Likewise.
The module descriptions need to be adjusted accordingly:
2017-05-20 Bruno Haible
argp, tsearch tests: Fix file lis
Jim Meyering wrote:
> diff --git a/tests/test-getopt.h b/tests/test-getopt.h
> index ce470c8..5c0e5b5 100644
> --- a/tests/test-getopt.h
> +++ b/tests/test-getopt.h
> @@ -17,6 +17,7 @@
> /* Written by Bruno Haible , 2009. */
>
> #include
> +#include "macros.h"
>
> /* The glibc/gnulib impleme
12 matches
Mail list logo
