Re: fuzzing

2017-05-17 Thread Tim Rühsen
On Mittwoch, 17. Mai 2017 19:10:40 CEST Bruno Haible wrote: > Hi Tim, > > > What about fuzzing ? > > I just work on OSS-Fuzz[1] integration for Wget2. Is There interest in a > > 'starter' for gnulib with a example fuzz code ? > > Gnulib by itself does not provide functionality that consumes input

Re: automated CI testing

2017-05-17 Thread Assaf Gordon
Hello, On Wed, May 17, 2017 at 09:20:33PM +0200, Tim Rühsen wrote: On Mittwoch, 17. Mai 2017 19:09:52 CEST Bruno Haible wrote: > What about automated / CI testing ? [...] Therefore what is more valuable for gnulib (IMO) is automated testing on 20 different platforms. Of course everybody w

Re: valgrind

2017-05-17 Thread Tim Rühsen
On Mittwoch, 17. Mai 2017 19:09:05 CEST Bruno Haible wrote: > Hi Tim, > > > How do I enable valgrind testing ? > > There is this doc [1] and this recent mail thread [2]. Ok, there seems to a misunderstanding. While I have no problems to setup/run most projects to use valgrind, I have problems t

Re: automated CI testing

2017-05-17 Thread Tim Rühsen
On Mittwoch, 17. Mai 2017 19:09:52 CEST Bruno Haible wrote: > Hi Tim, > > > What about automated / CI testing ? > > We (the Wget maintainers) recently set up a group 'gnuwget' on Gitlab > > with CI runners (Debian, CentOS, Fedora). I could add gnulib as a > > project so that it can use these runne

Re: fuzzing

2017-05-17 Thread Bruno Haible
Hi Tim, > What about fuzzing ? > I just work on OSS-Fuzz[1] integration for Wget2. Is There interest in a > 'starter' for gnulib with a example fuzz code ? Gnulib by itself does not provide functionality that consumes input. But Gnulib provides common coding patterns for packages that use the GN

Re: automated CI testing

2017-05-17 Thread Bruno Haible
Hi Tim, > What about automated / CI testing ? > We (the Wget maintainers) recently set up a group 'gnuwget' on Gitlab > with CI runners (Debian, CentOS, Fedora). I could add gnulib as a > project so that it can use these runners as well. The only thing to do > for the gnulib project is to add a .g

Re: valgrind

2017-05-17 Thread Bruno Haible
Hi Tim, > How do I enable valgrind testing ? There is this doc [1] and this recent mail thread [2]. Bruno [1] https://www.gnu.org/software/gnulib/manual/html_node/Running-self_002dtests-under-valgrind.html [2] https://lists.gnu.org/archive/html/bug-gnulib/2017-04/msg00041.html

Re: make coverage

2017-05-17 Thread Bruno Haible
Hi Tim, > 'make coverage' fails here due to two tests failing, thus no coverage > report is created. > I couldn't find a better solution. In the comment, you write "possible crash when compiled with -coverage". Our tests should not crash, with or without --coverage, on glibc systems. IMO we shou

some questions

2017-05-17 Thread Tim Rühsen
Hi, just a couple of questions... How do I enable valgrind testing ? What about automated / CI testing ? We (the Wget maintainers) recently set up a group 'gnuwget' on Gitlab with CI runners (Debian, CentOS, Fedora). I could add gnulib as a project so that it can use these runners as well. The o

make coverage

2017-05-17 Thread Tim Rühsen
Hi, 'make coverage' fails here due to two tests failing, thus no coverage report is created. Here is a patch to fix this by skipping those tests. I couldn't find a better solution. There still is Processing file gllib/gllib/unicase/special-casing-table.gperf genhtml: ERROR: cannot read /usr/o

Re: gnulib build/test ?

2017-05-17 Thread Tim Rühsen
Hi Bruno, On 05/17/2017 10:15 AM, Bruno Haible wrote: > Hi Tim, > > + Contributor's Quick Start Guide > > This does not belong in the README. The README is for first-time *users*. > For first-time *contributors*, many GNU packages have a HACKING file, > but gnulib already has a doc sect

Re: gnulib build/test ?

2017-05-17 Thread Bruno Haible
Hi Tim, > I put your description with some small amendments into the README. > Here's the patch. Thanks for being so pro-active. -Please see doc/gnulib-readme.texi for basic information about Gnulib. +Please create and read the docs with + + $ cd doc + $ make gnulib.html + $ xdg-open gnulib.h

Re: Fix memleak in parse-datetime

2017-05-17 Thread Bruno Haible
> Fixing a small resource leak. Thanks, applied! Bruno

Fix memleak in parse-datetime

2017-05-17 Thread Tim Rühsen
Fixing a small resource leak. With Best Regards, Tim From d52c2951f4d805042a9dcb4cc9de0a4cabe1999d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Wed, 17 May 2017 09:22:46 +0200 Subject: [PATCH] parse-datetime: Fix memleak * lib/parse-datetime.y (parse_datetime2): Cleanup o