Re: GNU LIB build fails on macOS 10.12.4

2017-04-08 Thread Zack Weinberg
> Please try the attached patch against Emacs master. > If it works I plan to install it into Emacs and propagate > it into Gnulib. This patch is incomplete. If gnulib cannot use __nonnull in getopt_{core,ext}.h, then there is no point trying to define it in getopt_cdefs.h. And you're going to n

Re: minus versus underscore in new getopt file names

2017-04-08 Thread Zack Weinberg
On Sat, Apr 8, 2017 at 5:42 AM, Paul Eggert wrote: > Now that I think about it, the longstanding Gnulib and GNU tradition is to > use minus in file names rather than underscore. How about if we rename the > newly-introduced getopt source files to use minus instead of underscore? I don't think gli

Re: GNU LIB build fails on macOS 10.12.4

2017-04-08 Thread Harald Maier
They __THROW and __nonnull are defined in „getopt_cdefs.h“.The gcc command isgcc -c    -MMD -MF deps/fstatat.d -MP    -g3 -O2 -I. -I../src -I. -I./../src  fstatat.cThe output from -E fstatat.i Description: Binary data Am 08.04.2017 um 10:24 schrieb Paul Eggert :[Following up on

Re: GNU LIB build fails on macOS 10.12.4

2017-04-08 Thread Harald Maier
Yes, this fixes the problem and compilation works without errors. Harald > Am 08.04.2017 um 11:38 schrieb Paul Eggert : > > Harald Maier wrote: >> They __THROW and __nonnull are defined in „getopt_cdefs.h“. > > Thanks, I think I see the problem. Either the compiler or some macOS header > does

minus versus underscore in new getopt file names

2017-04-08 Thread Paul Eggert
Now that I think about it, the longstanding Gnulib and GNU tradition is to use minus in file names rather than underscore. How about if we rename the newly-introduced getopt source files to use minus instead of underscore?

Re: GNU LIB build fails on macOS 10.12.4

2017-04-08 Thread Paul Eggert
Harald Maier wrote: They __THROW and __nonnull are defined in „getopt_cdefs.h“. Thanks, I think I see the problem. Either the compiler or some macOS header does "#define __nonnull _Nonnull", and this collides with glibc's use of __nonnull. Presumably Clang uses _Nonnull as a type qualifier an

Re: GNU LIB build fails on macOS 10.12.4

2017-04-08 Thread Paul Eggert
[Following up on http://bugs.gnu.org/26398 and CC'ing bug-gnulib and Zack Weinberg.] In file included from ./unistd.h:135: In file included from ./getopt_pfx_core.h:52: ./getopt_core.h:91:79: error: expected ';' after top level declarator extern int getopt (int ___argc, char *const *___argv, co