Re: Merge getopt from gnulib to glibc and vice versa, eliminate __need_getopt

2017-04-06 Thread Paul Eggert
Thanks for doing this, as Gnulib and Glibc should be better-synchronized. In the interests of helping this move along, I installed your proposed changes into Gnulib, with the attached additional minor patches, the first of which I hope you can incorporate into your Glibc proposal (the second pa

Merge getopt from gnulib to glibc and vice versa, eliminate __need_getopt

2017-04-06 Thread Zack Weinberg
The implementation of 'getopt' is shared between gnulib and glibc, but they have not been kept consistent in quite some time and there has been quite a bit of divergence. They also haven't really been *maintained* in either project. I set out simply to eliminate __need_getopt in both projects (se

Re: Trivial patches to silence -Wundef

2017-04-06 Thread Tim Rühsen
On 04/05/2017 11:08 PM, Paul Eggert wrote: > #pragma GCC diagnostic ignored "-Wundef" Thank you. Though I am aware of the diagnostic pragma, it needed your hint to have a closer look... it turned out I just have to change on central header file :-) (First I thought I had to do the change in each

Re: Trivial patches to silence -Wundef

2017-04-06 Thread Tim Rühsen
On 04/05/2017 10:59 PM, Bruno Haible wrote: > Hi Tim, > >> These patches silence tons of warnings here... >> 0001-lib-gettext.h-Avoid-Wundef-warningi-for-ENABLE_NLS.patch > > We cannot apply this patch. While gettext.m4 defines ENABLE_NLS to 1 > or doesn't define it at all, many developers use "#