Re: Trivial patches to silence -Wundef

2017-04-05 Thread Paul Eggert
On 04/05/2017 10:56 AM, Tim Rühsen wrote: while i can (and do) give the gnulib files their own CFLAGS, I can't and won't leave out -Wundef on my own C files. You can use something like this in your source files: #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wundef" #includ

Re: Trivial patches to silence -Wundef

2017-04-05 Thread Bruno Haible
Hi Tim, > These patches silence tons of warnings here... > 0001-lib-gettext.h-Avoid-Wundef-warningi-for-ENABLE_NLS.patch We cannot apply this patch. While gettext.m4 defines ENABLE_NLS to 1 or doesn't define it at all, many developers use "#defined ENABLE_NLS 0" to disable NLS from GNU gettext: A

Re: Trivial patches to silence -Wundef

2017-04-05 Thread Tim Rühsen
On Mittwoch, 5. April 2017 10:29:25 CEST Eric Blake wrote: > On 04/05/2017 08:47 AM, Tim Rühsen wrote: > > These patches silence tons of warnings here... > > In general, we do NOT try to make gnulib .c files '-Wundef'-clean. The > best solution is to not use -Wundef on gnulib compilation (even if

Re: Trivial patches to silence -Wundef

2017-04-05 Thread Eric Blake
On 04/05/2017 08:47 AM, Tim Rühsen wrote: > These patches silence tons of warnings here... In general, we do NOT try to make gnulib .c files '-Wundef'-clean. The best solution is to not use -Wundef on gnulib compilation (even if you want to use it on your .c files). Of course, that means that .h

Fix prototype of strerror_r() in lib/error.c

2017-04-05 Thread Tim Rühsen
Silences this warning error.c:114:1: warning: function declaration isn't a prototype [-Wstrict-prototypes] int strerror_r (); Regards, Tim From 1a41e02838d13d0c061e90081697af8a91d25fd0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Wed, 5 Apr 2017 15:58:22 +0200 Subject: [PA

Trivial patches to silence -Wundef

2017-04-05 Thread Tim Rühsen
These patches silence tons of warnings here... Regards, Tim From eefbed85b601624b71d7b3d2857c994d33e62f6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= Date: Wed, 5 Apr 2017 15:31:30 +0200 Subject: [PATCH 1/2] * lib/gettext.h: Avoid -Wundef warningi for ENABLE_NLS --- lib/gettext

Re: relocatable given GPL boilerplate despite asking for relocatable-lib-lgpl

2017-04-05 Thread Reuben Thomas
On 5 April 2017 at 03:08, Bruno Haible wrote: > > Do you have any objection to updating the "default" licenses on the files > > to GPL so that there's no discrepancy with the gnulib documentation? > > No objection. Fine with me. ​Thanks. I attach a patch to make this change.​ -- http://rrt.s