[PATCH v2] ptsname_r: leverage AC_HEADER_MAJOR

2016-11-26 Thread Mike Frysinger
The mountlist module changes were merged independently since my v1, but the ptsname module still hasn't been updated. These two modules use makedev/major/minor but don't have explicit checks for the functions. Use the existing autoconf macro which will probe some headers for use and set up some d

Re: bug#25029: shuf generates “Bad file descriptor” error on nfs but only when run as a background process

2016-11-26 Thread Paul Eggert
On 11/26/2016 04:18 PM, Pádraig Brady wrote: Does the freopen module now need to depend on the dup2 and open modules? For example using dup2(fd, fd) to test fd validity fails on Linux 2.6.29 I tried to avoid that dependency, by using code that checks errno after dup2 fails, so that the workar

Re: bug#25029: shuf generates “Bad file descriptor” error on nfs but only when run as a background process

2016-11-26 Thread Pádraig Brady
On 26/11/16 23:49, Paul Eggert wrote: > On 11/25/2016 06:00 PM, Paul Eggert wrote: >> Isn't that a bug in glibc freopen? It shouldn't fail ... merely >> because stdin doesn't have a valid file descriptor. If so, we should >> fix the Gnulib freopen module to work around the bug. > > I did that, b

Re: bug#25029: shuf generates “Bad file descriptor” error on nfs but only when run as a background process

2016-11-26 Thread Paul Eggert
On 11/25/2016 06:00 PM, Paul Eggert wrote: Isn't that a bug in glibc freopen? It shouldn't fail ... merely because stdin doesn't have a valid file descriptor. If so, we should fix the Gnulib freopen module to work around the bug. I did that, by installing the attached patches into Gnulib (firs

Re: [PATCH] dfa: addition of new state on demand

2016-11-26 Thread Norihiro Tanaka
Thanks for the review. I confirmed your changes, and I found no problem. > CC'ing this to grep-devel since that's where the hardy band of dfa > consumers hang out. I will also do it in next post for dfa.

[PATCH] maint: use a more standard return from mbrtowc test

2016-11-26 Thread Pádraig Brady
With this we can use this check in coreutils to find configure issues: grep -E '(program exited with status 1$|core dumped)' config.log * m4/mbrtowc.m4 (gl_MBRTOWC_C_LOCALE): Don't return 1 from the test program as this often indicates an unhandled case in the test program. (gl_MBRTOWC_INCOMPLET