Hi,
If pathconf (name, _PC_PATH_MAX) returns a PATH_MAX value > 2 GB,
the readlink call in canonicalize-lgpl.c line 292 may return a length > 2 GB,
therefore the implicit cast (assignment) to 'int' will produce a wrong value.
If you agree with this patch, it'd be a good idea to propagate it into
On 10/13/2016 12:14 PM, Eric Blake wrote:
I think a configure test based on -Werror=format would be
sufficient
What we have now should work for GCC 2.0 and later, whereas
-Werror=format is a much-newer GCC feature and so would be less portable.
if they are using some other compiler,
then ch
On Thu, Oct 13, 2016 at 1:50 AM, Pádraig Brady wrote:
> On 13/10/16 02:43, Daniel Richard G. wrote:
>> On Wed, 2016 Oct 12 11:04+0100, Pádraig Brady wrote:
>>>
>>> You only want to strdup once.
>>> So you could use a static to track that as is done in the AIX case.
>>
>> Ah, I see, the program nam
On 10/13/2016 01:50 PM, Eric Blake wrote:
> On 10/13/2016 01:23 PM, Paul Eggert wrote:
>> On 10/13/2016 06:36 AM, Eric Blake wrote:
>>> That's a bug in s390's system headers. Gnulib should be taught to work
>>> around it.
>>
>> Although this bug was reported fixed in glibc 2.20; see
>>
>> https://
On 10/13/2016 01:23 PM, Paul Eggert wrote:
> On 10/13/2016 06:36 AM, Eric Blake wrote:
>> That's a bug in s390's system headers. Gnulib should be taught to work
>> around it.
>
> Although this bug was reported fixed in glibc 2.20; see
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=16712
>
---
ChangeLog | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 89ba80f..32bddf8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -49,6 +49,12 @@
* lib/utimecmp.c (utimecmp): Do not apply "~" to a boolean.
Instead, make it explicit that we intend to app
On 10/13/2016 06:36 AM, Eric Blake wrote:
That's a bug in s390's system headers. Gnulib should be taught to work
around it.
Although this bug was reported fixed in glibc 2.20; see
https://sourceware.org/bugzilla/show_bug.cgi?id=16712
the Gnulib manual says the bug is still in glibc 2.24; see
On 10/07/2016 05:43 AM, Jiri Denemark wrote:
> GCC on s390 complains
>
> util/virconf.c: In function 'virConfGetValueSizeT':
> util/virconf.c:1220:9: error: format '%zu' expects argument of type
> 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=]
>
That's a bug in s390's system
On 13/10/16 02:43, Daniel Richard G. wrote:
> On Wed, 2016 Oct 12 11:04+0100, Pádraig Brady wrote:
>>
>> You only want to strdup once.
>> So you could use a static to track that as is done in the AIX case.
>
> Ah, I see, the program name never changes.
>
>> You can call free(NULL), so the last 3
