Re: secure_getenv + windows

2016-05-29 Thread Bruno Haible
Paul, > Thanks, that all looks good to me. OK, I've pushed it. > I don't know the distinction between runas and runas /env [1] explains it. I don't think there is a security pitfall here: The responsibility is with the user who runs a 'runas' command or installs a scripts that runs 'runas'. >

Re: secure_getenv + windows

2016-05-29 Thread Paul Eggert
Bruno Haible wrote: Also, Paul, why not add an implementation for Solaris, HP-UX, AIX, etc. as well? Find attached a proposed implementation for all platforms. For your review. Thanks, that all looks good to me. Nikos, I was demurring because I don't know MS-Windows, e.g., I don't know the d

Re: secure_getenv + windows

2016-05-29 Thread Bruno Haible
Hi Nikos, Thanks for the suggestion. But we need to distinguish native Windows and Cygwin. Native Windows does not have a setuid concept, but Cygwin has. [1] Also, in the code, the "# ifdef _WIN32" conditional is wrong. 1) It is a compiler-dependent conditional. In order to treat the GCC and

Re: secure_getenv + windows

2016-05-29 Thread Nikos Mavrogiannopoulos
On Sat, 2016-05-28 at 23:53 -0700, Paul Eggert wrote: > Nikos Mavrogiannopoulos wrote: > > > > secure_getenv() > > has no (known to me) meaning for windows, and that's why I'd expect > > that call there to behave as getenv(). > I'm afraid that this doesn't answer my question. I was asking why the