Re: [PATCH 1/2] test-framework-sh: port to NetBSD 7.0

2016-03-25 Thread Jim Meyering
On Fri, Mar 25, 2016 at 1:01 PM, Paul Eggert wrote: > On 03/25/2016 08:16 AM, Jim Meyering wrote: >> >> I know that mktemp's -t is not portable, but the code in >> init.sh was supposed to work around that. Did you see >> some place where that work-around failed? > > Ah, sorry, I misinterpreted the

Re: [PATCH 1/2] test-framework-sh: port to NetBSD 7.0

2016-03-25 Thread Paul Eggert
On 03/25/2016 08:16 AM, Jim Meyering wrote: I know that mktemp's -t is not portable, but the code in init.sh was supposed to work around that. Did you see some place where that work-around failed? Ah, sorry, I misinterpreted the debugging output. I saw a 'fail=1' and thought, "Oh, the script i

[PATCH 1/2] test-framework-sh: revert port to NetBSD 7.0

2016-03-25 Thread Paul Eggert
It was a false alarm; I misinterpreted Assaf Gordon's report. * tests/init.sh (testdir_prefix_, pfx_, template_length_): Restore. (test_dir_): Adjust to mktempd_ change. (mktempd_): Restore 2nd arg. Use -t again. (base_template_, template_, nx_): Resurrect old code. --- ChangeLog | 8 +++

[PATCH 2/2] test-framework-sh: minor cleanups

2016-03-25 Thread Paul Eggert
* tests/init.sh (testdir_prefix_): Output a trailing newline, since strictly speaking POSIX requires this. (setup_): Do not use the variable 'fail', as that makes the trace output harder to read ('fail' is typically used by tests to mean the test failed). Treat // portably. Check that new director

Re: [PATCH 1/2] test-framework-sh: port to NetBSD 7.0

2016-03-25 Thread Jim Meyering
On Fri, Mar 25, 2016 at 12:20 AM, Paul Eggert wrote: > Problem reported by Assaf Gordon in: http://bugs.gnu.org/23107#13 > * tests/init.sh (testdir_prefix_, pfx_, template_length_): > Remove. All uses removed. > (test_dir_): Adjust to mktempd_ change. > (mktempd_): Omit 2nd arg. Stop using -t, a

Re: [PATCH 2/2] Port better to Alpine Linux

2016-03-25 Thread Ludovic Courtès
Paul Eggert skribis: > + Port better to Alpine Linux > + Its diff implementation does not support -c, but does support -U3. Apparently it’s Busybox’s ‘diff’, so not specific to Alpine. Ludo’.

[PATCH 1/2] test-framework-sh: port to NetBSD 7.0

2016-03-25 Thread Paul Eggert
Problem reported by Assaf Gordon in: http://bugs.gnu.org/23107#13 * tests/init.sh (testdir_prefix_, pfx_, template_length_): Remove. All uses removed. (test_dir_): Adjust to mktempd_ change. (mktempd_): Omit 2nd arg. Stop using -t, as it is not portable. (base_template_, template_, nx_): Simplify

[PATCH 2/2] Port better to Alpine Linux

2016-03-25 Thread Paul Eggert
Its diff implementation does not support -c, but does support -U3. Problem reported by Assaf Gordon in: http://bugs.gnu.org/23107#13 * tests/init.sh (diff_opt_): New var. (compare_): Prefer diff -U3 to diff -c to plain diff. --- ChangeLog | 8 tests/init.sh | 12 +--- 2 files