Re: [PATCH 00/11] Android compatibility

On Wed, Feb 11, 2015 at 4:12 PM, Paul Eggert wrote: > Thanks for doing all that work! I pushed the first 10 patches and have > a couple of comments. I'll send a separate email about the 11th patch. > > Kevin Cernekee wrote: > >> FAIL: test-verify.sh >> >> >> compiler didn't

Re: [PATCH 11/11] getdtablesize: Fix RLIMIT_NOFILE fallback case

Kevin Cernekee wrote: @@ -99,8 +99,8 @@ rpl_getdtablesize(void) a smaller soft limit, the smaller limit is not enforced, so we might as well just report the hard limit. */ struct rlimit lim; - if (!getrlimit (RLIMIT_NOFILE, &lim) && lim.rlim_max != RLIM_INFINITY) -return

Re: [PATCH 00/11] Android compatibility

Thanks for doing all that work! I pushed the first 10 patches and have a couple of comments. I'll send a separate email about the 11th patch. Kevin Cernekee wrote: FAIL: test-verify.sh compiler didn't detect verification failure 1 ... test-verify is trying to perform com

[PATCH 09/11] signal_h: Fix Android build

* lib/signal.in.h: Add Android to the list of platforms that declare pthread_sigmask() in instead of . --- ChangeLog | 4 lib/signal.in.h | 8 +--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index d17b2220125b..6ed3de23809f 100644 --- a/Cha

[PATCH 08/11] net_if: Handle content-free system headers

* m4/net_if_h.m4: Check to make sure actually defines struct if_nameindex. If not, enable the replacement header. --- ChangeLog | 4 m4/net_if_h.m4 | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 8cd014b3cf58..d17b2220125b 100644 --- a

[PATCH 07/11] linkat_nofollow: Add fallback case for cross compiling

* m4/linkat.m4: Guess no for Darwin, yes otherwise. --- ChangeLog| 3 +++ m4/linkat.m4 | 18 -- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7e1fb9191b6d..8cd014b3cf58 100644 --- a/ChangeLog +++ b/ChangeLog @@ -39,6 +39,9 @@

[PATCH 11/11] getdtablesize: Fix RLIMIT_NOFILE fallback case

* lib/getdtablesize.c: Use rlim_cur instead of rlim_max, to match glibc behavior. test-getdtablesize and test-dup2 both assume they will be able to create a file descriptor numbered (getdtablesize()-1), and will fail if rlim_max > rlim_cur. --- ChangeLog | 6 ++ lib/getdtablesize.c

[PATCH 02/11] Assume unbroken ungetc() on Android

* m4/ungetc.m4: Add Android case to host OS check. The ungetc() test case passed when running on an Android host, and the code hasn't really changed since 2009. --- ChangeLog| 5 + m4/ungetc.m4 | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog

[PATCH 03/11] getdtablesize: Fix Android build

* m4/getdtablesize.m4: Add Android case to host OS check. Recent NDK versions have this symbol in the .so library (at least 32-bit platforms) but are missing the declaration in the header file, causing the m4 logic to guess incorrectly. --- ChangeLog | 6 ++ m4/getdtablesize.m4 | 4

[PATCH 06/11] euidaccess: Fix Android build

* modules/euidaccess (Depends-on): Add fcntl-h to ensure that AT_EACCESS gets declared. --- ChangeLog | 4 modules/euidaccess | 1 + 2 files changed, 5 insertions(+) diff --git a/ChangeLog b/ChangeLog index bbcc513261eb..7e1fb9191b6d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -35,6 +

[PATCH 04/11] localename: Fix Android build

* modules/localename (Depends-on): Add langinfo. --- ChangeLog | 3 +++ modules/localename | 1 + 2 files changed, 4 insertions(+) diff --git a/ChangeLog b/ChangeLog index c1a37f5f1504..6d8bffa4160f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -28,6 +28,9 @@ platforms) but are missi

[PATCH 05/11] getugroups: Fix Android build

* lib/getugroups.c: Don't reference unsupported {get,set,end}grent functions. --- ChangeLog| 4 lib/getugroups.c | 7 +-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6d8bffa4160f..bbcc513261eb 100644 --- a/ChangeLog +++ b/ChangeLog @@

[PATCH 10/11] duplocale: Fix Android build of duplocale-tests

* modules/duplocale-tests (Depends-on): Add langinfo, as the header is included by test-duplocale.c (but not by duplocale.c). * modules/duplocale-tests (configure.ac): Check for monetary.h. * tests/test-duplocale.c: Skip test if monetary.h is absent. * doc/posix-headers/monetary.texi: Add Android t

[PATCH 01/11] Fix FILE struct compatibility with Android API level >= 21

* lib/stdio-impl.h: Test explicitly for __ANDROID__ instead of __sferror. Recent versions of Bionic's stdio.h no longer define __sferror. * lib/fbufmode.c: Likewise. * lib/fflush.c: Likewise. * lib/fpurge.c: Likewise. * lib/freadable.c: Likewise. * lib/freadahead.c: Likewise. * lib/freading.c: Lik

[PATCH 00/11] Android compatibility

This patch series fixes several build failures and test failures seen when compiling gnulib with Bionic libc (Android NDK r10d). With these patches applied, I was able to compile each module listed by "gnulib-tool --list" except for gnumakefile and non-recursive-gnulib-prefix-hack, for ARM (32-bit

Re: New gnulib wrappers with glibc 2.21.

On 11/02/15 19:22, Paul Eggert wrote: > [Also cc'ing bug-gnulib.] > On 02/11/2015 08:05 AM, Joseph Myers wrote: >> These bit-patterns are considered to be trap representations > > Yes, this is not a standards-conformance issue. > >> with the gnulib implementation they are still trap representatio

Re: New gnulib wrappers with glibc 2.21.

[Also cc'ing bug-gnulib.] On 02/11/2015 08:05 AM, Joseph Myers wrote: These bit-patterns are considered to be trap representations Yes, this is not a standards-conformance issue. with the gnulib implementation they are still trap representations (not consistently behaving like NaNs), you've j

[PATCH v2] fts: avoid crash when a cycle is added while traversing

This could be triggered by auto-mounting a recursive bind mount. Reported by Michael Chapman in: https://bugzilla.redhat.com/1188498 * lib/fts.c (fts_read): Avoid removing the original hash table item when leaving a directory that caused a cycle, and preserve the FTS_DC flag. --- ChangeLog | 9 ++

Re: [PATCH] fts: fix a crash triggered by recursive bind mount

On 11/02/15 15:36, Kamil Dudka wrote: > Reported by Michael Chapman in: https://bugzilla.redhat.com/1188498 > * lib/fts.c (fts_read): Avoid removing the original hash table item > when leaving a directory that caused a cycle, and preserve the FTS_DC > flag. This looks good to me on first glance. I

[PATCH] fts: fix a crash triggered by recursive bind mount

Reported by Michael Chapman in: https://bugzilla.redhat.com/1188498 * lib/fts.c (fts_read): Avoid removing the original hash table item when leaving a directory that caused a cycle, and preserve the FTS_DC flag. --- ChangeLog | 8 lib/fts.c | 13 ++--- 2 files changed, 18 inserti