On Sat, 20 Dec 2014 18:20:06 -0800
Paul Eggert wrote:
> I'd rather not, as the idea is not gnulib-specific.
Thanks, I understood.
Norihiro Tanaka wrote:
how about "gl_assert" instead of "assure"?
I'd rather not, as the idea is not gnulib-specific.
On Sat, 20 Dec 2014 13:03:23 -0800
Paul Eggert wrote:
> That sort of thing looks like it'd be reasonably annoying in the long
> run. How about the attached patch instead?
I confirmed that it had already been committed.
Thanks.
On Sat, 20 Dec 2014 13:03:23 -0800
Paul Eggert wrote:
> Norihiro Tanaka wrote:
> > +#if NDEBUG
> > + close (cdb->fd);
> > +#else
> > bool close_fail = close (cdb->fd);
> > assert (! close_fail);
> > +#endif
>
> That sort of thing looks like it'd be reasonably annoying in the
Norihiro Tanaka wrote:
+#if NDEBUG
+ close (cdb->fd);
+#else
bool close_fail = close (cdb->fd);
assert (! close_fail);
+#endif
That sort of thing looks like it'd be reasonably annoying in the long run. How
about the attached patch instead?
>From 972fd2a46979d17458eb900235
Hello,
Please find here a new version of the patch, the original one unintentionally
broke the function when detecting error on invalid map file.
My apologies for the noise,
Best regards,
Christophe.
m4/ld-version-script.m4 | 36 ++--
1 file changed, 18 insertio
Autoconf propose a mechanism to cache the result of checks, so that a user
who needs to re-run configure can get a very fast result. Unfortunately,
the code in the macro gl_LD_VERSION_SCRIPT did not implement this feature,
so it would always spend time re-testing.
This patch inserts the AC_CACHE_C
If we set -DNDEBUG in CPPFLAGS, fail to build close_fail.c with
-Werror=unused-variable, as close_fail is used only to do assertion.
This patch avoids declaration of close_fail if defined NDEBUG.
$ LC_ALL=C make
make all-recursive
make[1]: Entering directory '/usr/src/grep-2.21'
Making all in po
