Re: iOS support for crt_externs.h

2014-12-10 Thread Daiki Ueno
Paul Eggert writes: > Problem reported by André Klitzing in: > http://lists.gnu.org/archive/html/bug-gnulib/2014-11/msg00013.html > * lib/unistd.in.h (environ): Do not include crt_externs.h on iOS. > --- > ChangeLog | 7 +++ > lib/unistd.in.h | 6 ++ > 2 files changed, 13 insertion

Re: printf-safe checks of invalid long double values

2014-12-10 Thread Pádraig Brady
On 28/11/14 15:57, Paul Eggert wrote: > Pádraig Brady wrote: > >> 3. Since glibc no longer crashes, and no-one has complained about >> these edge cases of invalid numbers, just avoid this replacement altogether >> but push for the improvement to output "nan" in these cases in glibc. > > Thanks, I

Re: [PATCH] posixtm: avoid compiler warning in a better way

2014-12-10 Thread Thien-Thi Nguyen
() Paul Eggert () Wed, 10 Dec 2014 00:44:59 -0800 Thien-Thi Nguyen wrote: > Is there a performance advantage as well for ‘strchr’? Well, the call is smaller, and that's a performance win. :-) Seriously, though, it doesn't matter: this code is never a performance bottleneck, so si

Re: [PATCH] posixtm: avoid compiler warning in a better way

2014-12-10 Thread Paul Eggert
Thien-Thi Nguyen wrote: Is there a performance advantage as well for ‘strchr’? Well, the call is smaller, and that's a performance win. :-) Seriously, though, it doesn't matter: this code is never a performance bottleneck, so simplicity is more important than efficiency here.

Re: [PATCH] posixtm: avoid compiler warning in a better way

2014-12-10 Thread Thien-Thi Nguyen
() Paul Eggert () Wed, 10 Dec 2014 00:01:05 -0800 We could, but why bother? The strchr call is easier to understand and makes for less machine code. Is there a performance advantage as well for ‘strchr’? -- Thien-Thi Nguyen GPG key: 4C807502 (if you're human and you know it)

Re: [PATCH] posixtm: avoid compiler warning in a better way

2014-12-10 Thread Paul Eggert
Thien-Thi Nguyen wrote: + dot = strchr (s, '.'); Can we use ‘memchr (s, '.', s_len)’ here? We could, but why bother? The strchr call is easier to understand and makes for less machine code.