Re: printf-safe checks of invalid long double values

2014-11-28 Thread Pádraig Brady
On 28/11/14 15:57, Paul Eggert wrote: > Pádraig Brady wrote: > >> 1. Include the snprintf-posix gnulib module to fix this od issue, >> (but that would also use the replacement code in many more cases). >> >> 2. Adjust gnulib's ftoastr() to use the lower level vasnprintf-posix. >> That would work,

Re: printf-safe checks of invalid long double values

2014-11-28 Thread Paul Eggert
Pádraig Brady wrote: 3. Since glibc no longer crashes, and no-one has complained about these edge cases of invalid numbers, just avoid this replacement altogether but push for the improvement to output "nan" in these cases in glibc. Thanks, I like this option the best.

Re: printf-safe checks of invalid long double values

2014-11-28 Thread Pádraig Brady
On 28/11/14 13:32, Ondřej Bílka wrote: > On Thu, Nov 27, 2014 at 08:37:59PM -0800, Paul Eggert wrote: >> Pádraig Brady wrote: >>> Are these checks backed up by corresponding replacement code? >>> Are these checks correct? >>> Why has glibc not been updated in the 7 years since the checks were

Re: printf-safe checks of invalid long double values

2014-11-28 Thread Pádraig Brady
On 28/11/14 04:37, Paul Eggert wrote: > Pádraig Brady wrote: >>Are these checks backed up by corresponding replacement code? >>Are these checks correct? >>Why has glibc not been updated in the 7 years since the checks were added? > > As I recall, this comes from an old dispute about wh

Re: printf-safe checks of invalid long double values

2014-11-28 Thread Ondřej Bílka
On Thu, Nov 27, 2014 at 08:37:59PM -0800, Paul Eggert wrote: > Pádraig Brady wrote: > > Are these checks backed up by corresponding replacement code? > > Are these checks correct? > > Why has glibc not been updated in the 7 years since the checks were added? > > As I recall, this comes from

[PATCH] doc: mention that _BSD_SOURCE is deprecated for _DEFAULT_SOURCE

2014-11-28 Thread Pádraig Brady
* doc/posix-functions/setjmp.texi: Defining _BSD_SOURCE will induce warnings unless _DEFAULT_SOURCE is also defined. --- doc/posix-functions/setjmp.texi | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/posix-functions/setjmp.texi b/doc/posix-functions/setjmp.texi