Re: "test-lock" stuck on FreeBSD

2014-09-04 Thread Assaf Gordon
On 09/04/2014 06:02 PM, Paul Eggert wrote: I'm afraid you're going to have to debug this one, as I don't have easy access to FreeBSD SadlyI will not be able to devote time for that in the near future. So it will have to wait. (yes, I know I could set it up in a virtual machine, but it's just

Re: tests fail: "test-lock" and "test-thread_create" with gcc 4.6/4.8

2014-09-04 Thread Assaf Gordon
On 09/04/2014 06:00 PM, Paul Eggert wrote: Assaf Gordon wrote: COLLECT_GCC=gcc-4.8 COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper Yes, it appears to be a bug in the Ubuntu link-time optimization. Could you please report it to Ubuntu? In the meantime I have installed into gn

Re: [PATCH] maintainer-makefile: add syntax check for useless ';;'

2014-09-04 Thread Jim Meyering
On Thu, Sep 4, 2014 at 12:18 PM, Eric Blake wrote: > Most instances of ;; in C code are mistakes, where the second > semicolon is a no-op. This rule tries to make it easy to flag > the typos occuring at the end of a statement. It intentionally > does not flag for(;;) loops, and misses grammar pr

Re: "test-lock" stuck on FreeBSD

2014-09-04 Thread Paul Eggert
I'm afraid you're going to have to debug this one, as I don't have easy access to FreeBSD (yes, I know I could set it up in a virtual machine, but it's just too painful to debug).

Re: tests fail: "test-lock" and "test-thread_create" with gcc 4.6/4.8

2014-09-04 Thread Paul Eggert
Assaf Gordon wrote: COLLECT_GCC=gcc-4.8 COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper Yes, it appears to be a bug in the Ubuntu link-time optimization. Could you please report it to Ubuntu? In the meantime I have installed into gnulib the attached patch, which

"test-lock" stuck on FreeBSD

2014-09-04 Thread Assaf Gordon
Hello, On FreeBSD 10, 9.3, 8.4 (running inside kvm), the test "test-lock" sometime gets stuck. It was found through libunistring but I've also reproduced it with the latest gnulib directly (v0.1-210-g4738e5a), by doing: ./gnulib/gnulib-tool --create-testdir --dir=test-thread --with-tests

[PATCH] maintainer-makefile: add syntax check for useless ';;'

2014-09-04 Thread Eric Blake
Most instances of ;; in C code are mistakes, where the second semicolon is a no-op. This rule tries to make it easy to flag the typos occuring at the end of a statement. It intentionally does not flag for(;;) loops, and misses grammar problems in comments if the problem occurs in the middle of th

tests fail: "test-lock" and "test-thread_create" with gcc 4.6/4.8

2014-09-04 Thread Assaf Gordon
Hello, On Ubuntu 14.04 LTS with GCC 4.6.4 and 4.8.2, the tests "test-lock" and "test-thread_create" fail. They do not fail on same system with GCC 4.4.7 or Clang-3.3 . Confirmed also by Daiki Uenu: http://lists.gnu.org/archive/html/bug-libunistring/2014-09/msg5.html From a brief look it s

Re: [PATCH] error: drop spurious semicolon

2014-09-04 Thread Eric Blake
On 09/04/2014 10:28 AM, Eric Blake wrote: > limited to .[ch] files (maybe .y as well). So looking at emacs.git > (commit 5c9a1ec6), I see: > > $ git grep '; *;' -- '**/*.[chy]' | grep -v 'for (.*; *;.*)' Repeating on glibc.git commit 41488498: elf/tst-deep1mod2.c: return baz () + xyzzy ();; i

Re: [PATCH] error: drop spurious semicolon

2014-09-04 Thread Eric Blake
On 09/04/2014 10:15 AM, Paul Eggert wrote: > I just checked the Emacs source code for this, and found some spurious > semicolons, but also found several legitimate instances in strings and > comments. Would the new rule work with those? The idea is to write the rule with a regex that catches as m

Re: [PATCH] error: drop spurious semicolon

2014-09-04 Thread Paul Eggert
I just checked the Emacs source code for this, and found some spurious semicolons, but also found several legitimate instances in strings and comments. Would the new rule work with those?

Re: [PATCH] error: drop spurious semicolon

2014-09-04 Thread Eric Blake
On 09/04/2014 09:57 AM, Jim Meyering wrote: > On Thu, Sep 4, 2014 at 8:11 AM, Ben Pfaff wrote: >> On Thu, Sep 04, 2014 at 06:28:19AM -0600, Eric Blake wrote: >>> Noticed this while writing a syntax check rule to look for bogus >>> doubled semicolons. If there's interest, I could add this rule >>>

Re: [PATCH] error: drop spurious semicolon

2014-09-04 Thread Jim Meyering
On Thu, Sep 4, 2014 at 8:11 AM, Ben Pfaff wrote: > On Thu, Sep 04, 2014 at 06:28:19AM -0600, Eric Blake wrote: >> Noticed this while writing a syntax check rule to look for bogus >> doubled semicolons. If there's interest, I could add this rule >> to maint.mk: >> >> # Except for shell files and f

Re: [PATCH v2] gnulib-tool: Download PO files

2014-09-04 Thread Mathieu Anquetin
On Thu, Sep 4, 2014 at 5:12 PM, Ben Pfaff wrote: > On Thu, Sep 04, 2014 at 08:54:47AM +0200, Mathieu Anquetin wrote: >> These two patches change the behavior of gnulib-tool for downloading PO >> files from the Translation Project. It synces it with what is being done >> by the build-aux/bootstrap

Re: [PATCH v2] gnulib-tool: Download PO files

2014-09-04 Thread Ben Pfaff
On Thu, Sep 04, 2014 at 08:54:47AM +0200, Mathieu Anquetin wrote: > These two patches change the behavior of gnulib-tool for downloading PO > files from the Translation Project. It synces it with what is being done > by the build-aux/bootstrap script (falling back to wget when rsync > isn't availab

Re: [PATCH] error: drop spurious semicolon

2014-09-04 Thread Ben Pfaff
On Thu, Sep 04, 2014 at 06:28:19AM -0600, Eric Blake wrote: > Noticed this while writing a syntax check rule to look for bogus > doubled semicolons. If there's interest, I could add this rule > to maint.mk: > > # Except for shell files and for loops, double semicolon is probably a mistake > sc_pr

[PATCH] error: drop spurious semicolon

2014-09-04 Thread Eric Blake
* lib/error.c (__error_at_line): Fix ';;'. Signed-off-by: Eric Blake --- Pushing as trivial. Noticed this while writing a syntax check rule to look for bogus doubled semicolons. If there's interest, I could add this rule to maint.mk: # Except for shell files and for loops, double semicolon is