[PATCH] lib/isatty.c - Remove IsConsoleHandle(h)

2014-06-08 Thread mart0258
isatty.c contains an "optimized test" to determine whether or not something is sent to terminal based on the low two bits.  I don't see the purpose behind the optimization.  It's only called after the _isatty(fd), meaning gnulib already has an accurate confirmation on whether or not the call i

'select' on MS-Windows returns without waiting for pipes

2014-06-08 Thread Eli Zaretskii
The gnulib implementation of 'select' for MS-Windows returns immediately with a zero value when it is called to wait for input from an anonymous pipe (e.g., a pipe created by a call to 'pipe' or 'pipe2'). This was discussed here in this thread: http://lists.gnu.org/archive/html/bug-gnulib/2011-

Return value of 'times' on MS-Windows is constant and overflows

2014-06-08 Thread Eli Zaretskii
The gnulib implementation of 'times' for MS-Windows uses the process creation time returned by the GetProcessTimes API to construct the value that the function should return. This has 2 problems: . The value is constant: every call to 'times' within the same process returns the same value.