Re: test-getlogin false failure in non login shells

2014-05-22 Thread Pádraig Brady
On 05/22/2014 05:40 PM, Eric Blake wrote: >>/* getlogin_r() fails when stdin is not connected to a tty. */ >> - ASSERT (err == ENOTTY >> + ASSERT (errno == ENOTTY >>|| errno == EINVAL /* seen on Linux/SPARC */ >>|| errno == ENXIO > > So this shoul

Re: test-getlogin false failure in non login shells

2014-05-22 Thread Eric Blake
On 05/22/2014 10:25 AM, Pádraig Brady wrote: > Drats sorry. This shows up when the ttyname_r module is also used, > thus setting HAVE_TTYNAME (which I forgot to do), thus triggering > the invalid test code. > > I've fixed this up in the attached and pushed. > > sorry for the trouble. > > Pádraig

Re: test-getlogin false failure in non login shells

2014-05-22 Thread Pádraig Brady
On 05/22/2014 04:39 PM, Tom G. Christensen wrote: > On 19/05/14 14:37, Pádraig Brady wrote: >> FYI I just pushed the attached to sync test-getlogin_r.c >> with the recent changes in test-getlogin.c >> > > This broke the build on CentOS 6. > > depbase=`echo test-getlogin_r.o | sed 's|[^/]*$|.deps/

Re: test-getlogin false failure in non login shells

2014-05-22 Thread Tom G. Christensen
On 19/05/14 14:37, Pádraig Brady wrote: FYI I just pushed the attached to sync test-getlogin_r.c with the recent changes in test-getlogin.c This broke the build on CentOS 6. depbase=`echo test-getlogin_r.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ gcc -std=gnu99 -DHAVE_CONFIG_H -I. -DGNU

[PATCH] fchdir: port 'open' and 'close' redefinitions to AIX 7.1

2014-05-22 Thread Paul Eggert
* lib/chown.c, lib/clean-temp.c, lib/copy-file.c, lib/execute.c: * lib/fsusage.c, lib/gc-gnulib.c, lib/javacomp.c, lib/mountlist.c: * lib/openat-proc.c, lib/pagealign_alloc.c, lib/progreloc.c: * lib/spawn-pipe.c: Do not #undef 'open' and 'close'. AIX 7 does '#define open open64' and then 'int open

Re: [PATCH] Added a module stringops that provides STREQ and STRNEQ

2014-05-22 Thread Paul Eggert
Jim Meyering wrote: What about the conflict with modules/streq? There are over 300 uses of STREQ in gnulib and coreutils. Are you suggesting to change all of those? Yes. But if this is too much all at once, let's just call the inline function 'STREQ'. We can rename it to 'streq' later, if an