Re: strerror_r.c doesn't compile if CC=g++

2014-02-24 Thread Werner LEMBERG
Ping! Werner == > [v0.1-78-g47f93b0] > > The following patch is necessary to make `strerror_r.c' compile if > CC=g++. Similar code is already used for the autoconf test. > > > Werner > >

Re: bug#16843: Error caused due to regression in git

2014-02-24 Thread Darshit Shah
On Mon, Feb 24, 2014 at 9:05 PM, Eric Blake wrote: > On 02/24/2014 12:53 PM, Eric Blake wrote: > > Yay - you confirmed that the solution that works for both versions of > > git is to ensure that we provide exactly one argument to the foreach > > command, where that argument gets passed through th

Re: bug#16843: Error caused due to regression in git

2014-02-24 Thread Eric Blake
On 02/24/2014 12:53 PM, Eric Blake wrote: > Yay - you confirmed that the solution that works for both versions of > git is to ensure that we provide exactly one argument to the foreach > command, where that argument gets passed through the shell with > identical results. I'll patch maint.mk shortl

Re: bug#16843: Error caused due to regression in git

2014-02-24 Thread Eric Blake
On 02/24/2014 12:37 PM, Darshit Shah wrote: >>> Based on the test that is failing, can you please show the output of: >>> >>> git submodule --quiet foreach echo 'a b' '"c d"' >> What about: >> >> git submodule --quiet foreach 'echo a b "c d" "$sha1"' >> > > The first command: > git subm

Re: bug#16843: Error caused due to regression in git

2014-02-24 Thread Darshit Shah
On Mon, Feb 24, 2014 at 3:04 PM, Eric Blake wrote: > On 02/24/2014 07:00 AM, Eric Blake wrote: > > > > > Based on the test that is failing, can you please show the output of: > > > > git submodule --quiet foreach echo 'a b' '"c d"' > > > > On my version (1.8.5.3), I get 'a b c d' (that is, e

Re: [bug-diffutils] bug#16848: diff reports a diff on identical lines

2014-02-24 Thread Paul Eggert
On 02/24/2014 11:31 AM, Jim Meyering wrote: If you find the time, would you please also add a test case like the one Vincent posted? I'm afraid that'd be iffy, as there was no bug -- in the test case, 'diff' had correct behavior. In general, there are a lot of correct outputs for 'diff', and

Re: [bug-diffutils] bug#16848: diff reports a diff on identical lines

2014-02-24 Thread Jim Meyering
On Sun, Feb 23, 2014 at 10:59 PM, Paul Eggert wrote: > Thanks for the bug report. > > I applied the attached three patches; the first is to gnulib and changes > gnulib's diffseq module to handle that case better, the second is to > diffutils and brings diffutils up to the latest gnulib, and the th

Re: bug#16843: Error caused due to regression in git

2014-02-24 Thread Eric Blake
thanks [adding gnulib] On 02/22/2014 02:01 AM, Darshit Shah wrote: > automake --version: 1.14.1 > autoconf --version: 2.69 > > The error occured when attempting to run the test suite GNU Wget's git > source. > `make` works correctly, but `make check` happens to fail with the following > output: >

Re: bug#16843: Error caused due to regression in git

2014-02-24 Thread Eric Blake
On 02/24/2014 07:00 AM, Eric Blake wrote: > > Based on the test that is failing, can you please show the output of: > > git submodule --quiet foreach echo 'a b' '"c d"' > > On my version (1.8.5.3), I get 'a b c d' (that is, echo saw three > arguments rather than 2, where only my 'c d' arg