Re: Hanging conftest

2013-11-27 Thread Siddhesh Poyarekar
On Wed, Nov 27, 2013 at 10:27:20AM -0700, Eric Blake wrote: > [adding glibc] > > On 11/27/2013 09:58 AM, Michal Privoznik wrote: > > Hey guys, > > > > I've just discovered a bug, well a hang in conftest. This is what I ran: > > > > libvirt.git $ git clean -fxd; ./autogen.sh --system > > > > and

Re: [PATCH] ignore-value: prefer GCC version back through 2.0

2013-11-27 Thread Eric Blake
On 11/27/2013 03:55 PM, Paul Eggert wrote: > While reading ignore-value.h I found that the code didn't match > the comments, so I took the liberty of changing both (!) > as described below. Please feel free to revert if I messed up. > > + > +ignore-value: prefer GCC version back through 2.0

Re: small improvements to selinux-h

2013-11-27 Thread Pádraig Brady
On 11/27/2013 10:24 PM, Paul Eggert wrote: > Thanks, that all looks good, one small nit: > >> +typedef char* security_context_t; > > GNU style is to say "char *id" rather than "char* id". > pushed. thanks, Pádraig.

Re: [PATCH] ignore-value: prefer GCC version back through 2.0

2013-11-27 Thread Pádraig Brady
On 11/27/2013 10:55 PM, Paul Eggert wrote: > -/* The __attribute__((__warn_unused_result__)) feature > - is available in gcc versions 3.4 and newer, > - while the typeof feature has been available since 2.7 at least. */ > -#if 3 < __GNUC__ + (4 <= __GNUC_MINOR__) > +/* The __attribute__((__war

[PATCH] ignore-value: prefer GCC version back through 2.0

2013-11-27 Thread Paul Eggert
While reading ignore-value.h I found that the code didn't match the comments, so I took the liberty of changing both (!) as described below. Please feel free to revert if I messed up. --- ChangeLog | 9 + lib/ignore-value.h | 8 2 files changed, 13 insertions(+), 4 dele

Re: small improvements to selinux-h

2013-11-27 Thread Paul Eggert
Thanks, that all looks good, one small nit: > +typedef char* security_context_t; GNU style is to say "char *id" rather than "char* id".

small improvements to selinux-h

2013-11-27 Thread Pádraig Brady
Attached is an improvement to selinux-h that changes the security_context_t stub type to more flexible. Also a few more stub functions were added. These were noticed while implementing new selinux functionality in coreutils, and while not required there, are probably worth including. thanks, Pádra

Re: Hanging conftest

2013-11-27 Thread Eric Blake
[adding glibc] On 11/27/2013 09:58 AM, Michal Privoznik wrote: > Hey guys, > > I've just discovered a bug, well a hang in conftest. This is what I ran: > > libvirt.git $ git clean -fxd; ./autogen.sh --system > > and all looked good until this: > > checking whether readlink signature is correct

Hanging conftest

2013-11-27 Thread Michal Privoznik
Hey guys, I've just discovered a bug, well a hang in conftest. This is what I ran: libvirt.git $ git clean -fxd; ./autogen.sh --system and all looked good until this: checking whether readlink signature is correct... yes checking whether readlink handles trailing slash correctly... yes checking

Re: [PATCH] pty: Activate the signature wrapper of forkpty.

2013-11-27 Thread Eric Blake
On 11/27/2013 08:20 AM, Mats Erik Andersson wrote: > Hello there, > > the signature wrapper rpl_forkpty() intended for BSD, where > there are differences in const-declarations, never takes effect. > Hence the native forkpty() is never used in any *BSD. > > The problem is that the preprocessor mac

[PATCH] pty: Activate the signature wrapper of forkpty.

2013-11-27 Thread Mats Erik Andersson
Hello there, the signature wrapper rpl_forkpty() intended for BSD, where there are differences in const-declarations, never takes effect. Hence the native forkpty() is never used in any *BSD. The problem is that the preprocessor macro HAVE_FORKPTY is never defined. A patch follows. Best regards,