Re: _GL_INLINE_HEADER_BEGIN/END left behind

2013-08-28 Thread Paul Eggert
Eric Blake wrote: > Just using this file as an example; your preprocessor indentation > doesn't match the prevailing style of # always in column 1. That indentation style dates back to the good old days when it wasn't portable to put '#error' in column 1. gcc -Wtraditional still warns about this;

Re: _GL_INLINE_HEADER_BEGIN/END left behind

2013-08-28 Thread Eric Blake
On 08/28/2013 07:50 PM, Paul Eggert wrote: > Sure, that's easy enough. I pushed this: > > +++ b/lib/gl_oset.h > @@ -21,6 +21,9 @@ > #include > #include > > +#ifndef _GL_INLINE_HEADER_BEGIN > + #error "Please include config.h first." > +#endif > _GL_INLINE_HEADER_BEGIN > #ifndef GL_OSET_IN

Re: _GL_INLINE_HEADER_BEGIN/END left behind

2013-08-28 Thread Paul Eggert
Sure, that's easy enough. I pushed this: headers: check that _GL_INLINE_HEADER_BEGIN is defined Suggested by Bruce Korb in: http://lists.gnu.org/archive/html/bug-gnulib/2013-08/msg00070.html * doc/extern-inline.texi (extern inline): Suggest checking that _GL_INLINE_HEADER_BEGIN is defined. * lib/

Re: [bug #35580] bootstrap is not portable to OpenBSD

2013-08-28 Thread Pádraig Brady
On 08/17/2013 10:36 PM, Pádraig Brady wrote: > On 08/11/2013 09:53 PM, Mike Miller wrote: >> On Fri, Aug 09, 2013 at 16:34:24 +0100, Pádraig Brady wrote: >>> Excellent. I intend to push the attached change to bootstrap so, >>> that includes sha1 in the list now it's compatible, so therefore >>> not

Re: _GL_INLINE_HEADER_BEGIN/END left behind

2013-08-28 Thread Bruce Korb
On 08/28/13 15:50, Bruce Korb wrote: The compile error message: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I../lib -I../src -I../lib -I../libopts \ -I../libopts -g -O2 -MT pw-pw.o -MD -MP -MF .deps/pw-pw.Tpo \ -c -o pw-pw.o `test -f 'pw.c' || echo './'`pw.c In file included from pw.h:47:0

Re: _GL_INLINE_HEADER_BEGIN/END left behind

2013-08-28 Thread Eric Blake
On 08/28/2013 04:55 PM, Eric Blake wrote: > On 08/28/2013 04:50 PM, Bruce Korb wrote: >> The compile error message: >> >>> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I../lib -I../src -I../lib >>> -I../libopts \ >>> -I../libopts -g -O2 -MT pw-pw.o -MD -MP -MF .deps/pw-pw.Tpo \ >>> -c -o pw-pw.o

Re: _GL_INLINE_HEADER_BEGIN/END left behind

2013-08-28 Thread Eric Blake
On 08/28/2013 04:50 PM, Bruce Korb wrote: > The compile error message: > >> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I../lib -I../src -I../lib >> -I../libopts \ >> -I../libopts -g -O2 -MT pw-pw.o -MD -MP -MF .deps/pw-pw.Tpo \ >> -c -o pw-pw.o `test -f 'pw.c' || echo './'`pw.c >> In file inc

_GL_INLINE_HEADER_BEGIN/END left behind

2013-08-28 Thread Bruce Korb
The compile error message: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I../lib -I../src -I../lib -I../libopts \ -I../libopts -g -O2 -MT pw-pw.o -MD -MP -MF .deps/pw-pw.Tpo \ -c -o pw-pw.o `test -f 'pw.c' || echo './'`pw.c In file included from pw.h:47:0, from pw.c:20: ../li

Request to relicense hash gnulib module to LGPLv2+

2013-08-28 Thread Richard W.M. Jones
libguestfs (an LGPLv2+ library) uses the 'hash' module, which turns out to be "GPL". Actually this happened because we started to use it in a separate GPL'd utility program, but later on included this functionality in the core library, copying the same code from the utility but not checking the li

Re: relicense module spawn-pipe

2013-08-28 Thread Eric Blake
On 08/28/2013 08:19 AM, Or Goshen wrote: > This patch will make the module usable from a library context, it will not > call error() unless specifically asked to. > Can you please apply it to the trunk That depends on whether the patch is deemed reasonable; and if non-trivial, you may also need to

Re: relicense module spawn-pipe

2013-08-28 Thread Or Goshen
This patch will make the module usable from a library context, it will not call error() unless specifically asked to. Can you please apply it to the trunk and ask the maintainer to relicense to LGPL ? Thanks, Or On Mon, Aug 26, 2013 at 4:04 PM, Eric Blake wrote: > [please don't top-post] > >