[PATCH 13/13] extern-inline: no 'static inline'

2012-11-08 Thread Paul Eggert
* m4/extern-inline.m4 (gl_EXTERN_INLINE): Do not require AC_C_INLINE. (_GL_INLINE, _GL_EXTERN_INLINE): Define as 'static', not as 'static inline', for older compilers. --- ChangeLog | 6 ++ m4/extern-inline.m4 | 5 ++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/

[PATCH 12/13] snippet/warn-on-use: no 'static inline'

2012-11-08 Thread Paul Eggert
* build-aux/snippet/warn-on-use.h: Remove unnecessary 'inline' in comment. --- ChangeLog | 4 build-aux/snippet/warn-on-use.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 8e6714b..f1c350a 100644 --- a/ChangeLog +++ b/C

[PATCH 11/13] rbtree-list, rbtreehash-list: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/gl_anyrbtree_list2.h (rotate_left, rotate_right): * lib/gl_anytree_list2.h (node_at): * lib/gl_anytreehash_list1.h (hash_resize_after_add) (gl_oset_first, add_nodes_to_buckets): Now static, not static inline. --- ChangeLog | 7 +++ lib/gl_anyrbtree_list2.h | 4 ++-- li

[PATCH 10/13] regex: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/regex_internal.c (calc_state_hash): * lib/regex_internal.h (bitset_set, bitset_clear, bitset_contain) (bitset_empty, bitset_set_all, bitset_copy, bitset_not, bitset_merge) (bitset_mask, re_string_char_size_at, re_string_wchar_at): Now static, not static inline. (inline) [__GNUC__ < 3 && _LIBC

[PATCH 09/13] xvasprintf: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/xvasprintf.c (xstrcat): Now static, not static inline. * m4/xvasprintf.m4 (gl_XVASPRINTF): Do not require AC_C_INLINE. --- ChangeLog| 6 ++ lib/xvasprintf.c | 2 +- m4/xvasprintf.m4 | 9 +++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeL

[PATCH 08/13] parse-datetime, parse-duration: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/parse-datetime.y (to_uchar): * lib/parse-duration.c (str_const_to_ul, str_const_to_l) (scale_n_add): Now static, not static inline. * m4/parse-datetime.m4 (gl_PARSE_DATETIME): * modules/parse-duration (configure.ac): Do not require AC_C_INLINE. --- ChangeLog | 9 + lib/p

[PATCH 07/13] getaddrinfo: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/getaddrinfo.c (validate_family): Now static, not static inline. * m4/getaddrinfo.m4 (gl_PREREQ_GETADDRINFO): Do not require AC_C_INLINE. --- ChangeLog | 6 ++ lib/getaddrinfo.c | 2 +- m4/getaddrinfo.m4 | 3 +-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Chang

[PATCH 06/13] ftruncate, fts, lstat, openat, raise: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/ftruncate.c (chsize_nothrow): * lib/fts.c (opendirat, diropen): * lib/lstat.c (orig_lstat): * lib/openat.c (orig_openat): * lib/raise.c (raise_nothrow): Now static, not static inline. * m4/ftruncate.m4 (gl_PREREQ_FTRUNCATE): * m4/fts.m4 (gl_FUNC_FTS_CORE): * m4/lstat.m4 (gl_PREREQ_LSTAT): * m

[PATCH 05/13] fflush, stat: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/fflush.c (clear_ungetc_buffer_preserving_position) (clear_ungetc_buffer, disable_seek_optimization) (restore_seek_optimization, update_fpos_cache): * lib/stat.c (orig_stat): Now static, not static inline. * m4/fflush.m4 (gl_PREREQ_FFLUSH): * m4/stat.m4 (gl_PREREQ_STAT): Do not require AC_C_IN

[PATCH 04/13] error, filevercmp: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/error.c (is_open, flush_stdout): * lib/filevercmp.c (order): Now static, not static inline. * m4/error.m4 (gl_PREREQ_ERROR): * modules/filevercmp (configure.ac): Do not require AC_C_INLINE. --- ChangeLog | 8 lib/error.c| 4 ++-- lib/filevercmp.c | 2 +- m4/error.

[PATCH 03/13] dup, execute, fatal-signal, etc.: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/dup.c (dup_nothrow): * lib/execute.c (nonintr_close, nonintr_open): * lib/fatal-signal.c (uninstall_handlers, install_handlers): * lib/fopen.c (orig_fopen): * lib/freadseek.c (freadptrinc): * lib/freopen.c (orig_freopen): * lib/fstat.c (orig_fstat, fstat_nothrow): * lib/get-rusage-as.c (get_r

[PATCH 02/13] c-strtod, memcoll, readutmp: no 'static inline'

2012-11-08 Thread Paul Eggert
* lib/c-strtod.c (c_locale): * lib/memcoll.c (strcoll_loop): * lib/readutmp.c (desirable_utmp_entry): Now static, not static inline. * m4/c-strtod.m4 (gl_C_STRTOD, gl_C_STRTOLD): * m4/memcoll.m4 (gl_MEMCOLL): * m4/readutmp.m4 (gl_READUTMP): Do not require AC_C_INLINE. --- ChangeLog | 10 +

[PATCH 01/13] arctwo, md4, md5, sha1, sha256, sha512: no 'static inline'

2012-11-08 Thread Paul Eggert
[This is a first in a series of patches to omit 'inline' when it's not needed.] * lib/arctwo.c (to_uchar): * lib/md4.c (set_uint32): * lib/md5.c (set_uint32): * lib/sha1.c (set_uint32): * lib/sha256.c (set_uint32): * lib/sha512.c (set_uint64): Now static, not static inline. This is a bit simpler,

[PATCH] tests/nap.h: avoid warning about unused variable

2012-11-08 Thread Jim Meyering
This fixes a "make check" build warn/failure in coreutils: make[5]: *** [test-fchownat.o] Error 1 In file included from test-utimens-common.h:33:0, from test-futimens.h:17, from test-fdutimensat.c:33: nap.h: In function 'nap_works': nap.h:5

Re: Libtool library used but 'LIBTOOL' is undefined

2012-11-08 Thread Dave Goodell
On Nov 8, 2012, at 1:19 PM CST, Stefano Lattarini wrote: > On 11/08/2012 07:56 PM, Bruce Korb wrote: >> >>> autoreconf: configure.ac: not using Libtool […] >>> lib/Makefile.am:31: error: Libtool library used but 'LIBTOOL' is undefined >>> lib/Makefile.am:31: The usual way to define 'LIBTOOL' is

Re: Libtool library used but 'LIBTOOL' is undefined

2012-11-08 Thread Bruce Korb
Hi Dave, Stefano, On Thu, Nov 8, 2012 at 11:40 AM, Dave Goodell wrote: > On Nov 8, 2012, at 1:19 PM CST, Stefano Lattarini wrote: > >> On 11/08/2012 07:56 PM, Bruce Korb wrote: >> I'd expect its definition to be brought in by the 'libtoolize' call >> issued by autoreconf; but then I see, in the o

Re: Libtool library used but 'LIBTOOL' is undefined

2012-11-08 Thread Stefano Lattarini
On 11/08/2012 07:56 PM, Bruce Korb wrote: > automake is trying to tell me something, but I cannot make out exactly what. > The literal meaning of the messages is pretty clear, but what they caution > about are things that appear to me to be correct. > >> autoreconf --force --install --verbose --sy

Libtool library used but 'LIBTOOL' is undefined

2012-11-08 Thread Bruce Korb
automake is trying to tell me something, but I cannot make out exactly what. The literal meaning of the messages is pretty clear, but what they caution about are things that appear to me to be correct. > autoreconf --force --install --verbose --symlink > autoreconf: Entering directory `.' > autore

Utility functions

2012-11-08 Thread Dmitry Bogatov
Hello, Gnulib team. I have two questions or proposals. First, is trivial function like this static inline void * xrangedup (const void *begin, const void *end) { return xstrdup (begin, (char *) end - (char *) begin); } I think, that functions like this implemented over and o

Re: [PATCH] fcntl-h: default O_SEARCH, O_EXEC to O_PATH if available

2012-11-08 Thread Paul Eggert
On 11/07/2012 11:34 PM, Jim Meyering wrote: > + mkdir -mu=rwx,g=rx,o=w,-s,+t t > mkdir: cannot change permissions of 't': Bad file descriptor Thanks for mentioning that. Yes, the O_PATH was the culprit. I backed out most of it, as follows. Arguably this is a Linux kernel bug with fchmod.

Re: bug#12820: gnulib testsuite failure in latest master

2012-11-08 Thread Stefano Lattarini
On 11/08/2012 08:44 AM, Paul Eggert wrote: > Ouch, I read your strace output incorrectly: it was napping > for 20 ms, not 2 s. Still, there should be no need to nap > for that long; 1 ms should suffice on your platform. > > I installed the following patch to cause the test > to take shorter naps.