Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Paul Eggert
On 07/20/2012 09:17 AM, Joachim Schmitz wrote: > The coreutils config.hin in 8.17 no more defines any of RAW_DECL_* functions, > which were present in 8.15. Can we expect more problems because of this? Sorry, I've lost context -- there has been a blizzard of emails in this thread and I don't know

verify usage [was: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code]

2012-07-20 Thread Eric Blake
On 07/19/2012 08:15 AM, Eric Blake wrote: > > I'll have to see if I can come up with a solution in upstream gnulib > that expands verify() in such a way that works with -Wnested-externs. > I'm pushing this documentation aid, so that the next time this question comes up, we have something to poin

Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code

2012-07-20 Thread Eric Blake
On 07/20/2012 04:26 PM, Eric Blake wrote: > +# define virAtomicIntGet(atomic) \ > +(__extension__ ({ \ > +verify (sizeof(*(atomic)) == sizeof(int)); \ > within func

Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code

2012-07-20 Thread Eric Blake
On 07/20/2012 12:36 AM, Hu Tao wrote: +# define virAtomicIntGet(atomic) \ +(__extension__ ({ \ +verify (sizeof(*(atomic)) == sizeof(int)); \ +(v

[PATCH] maint.mk: forbid exit(-1)

2012-07-20 Thread Eric Blake
Libvirt accidentally had an 'exit (-1)' which got by the syntax checker; generally, exiting with 255 is not a wise idea. * top/maint.mk (sc_prohibit_magic_number_exit): Detect negatives. Signed-off-by: Eric Blake --- ChangeLog|5 + top/maint.mk |5 +++-- 2 files changed, 8 inser

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Stefano Lattarini
On 07/20/2012 05:19 PM, Joachim Schmitz wrote: > I've been told that git needs python, and in a newer version, for > getting it installed. > That is false; quoting the comments in the git Makefile: Define NO_PYTHON if you do not want Python scripts or libraries at all. > Haven't verified that y

Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code

2012-07-20 Thread Eric Blake
On 07/20/2012 12:36 AM, Hu Tao wrote: >>> The `verify' lines cause building warnings: >>> >>> cc1: warnings being treated as errors >>> util/virobject.c: In function 'virClassNew': >>> util/virobject.c:74:99: error: nested extern declaration of >>> '_gl_verify_function2' [-Wnested-externs] >> >> W

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Joachim Schmitz
> From: Stefano Lattarini [mailto:stefano.lattar...@gmail.com] > Sent: Friday, July 20, 2012 4:50 PM > To: Joachim Schmitz > Cc: 'Jim Meyering'; 'Paul Eggert'; bug-gnulib@gnu.org; 'Eric Blake'; > 10...@debbugs.gnu.org; 'Schmitz, Joachim'; nagendra...@hp.com > Subject: Re: bug#10305: coreutils-8.14,

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Joachim Schmitz
> From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Friday, July 20, 2012 4:48 PM > To: Joachim Schmitz > Cc: 'Jim Meyering'; 'Paul Eggert'; bug-gnulib@gnu.org; nagendra...@hp.com; > 10...@debbugs.gnu.org; 'Schmitz, Joachim' > Subject: Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF > >

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: ... >> You can make it easier for us to process your coreutils patches by > separating >> them into conceptually-related sets, with commit log entries following >> HACKING's guidelines. > > OK, will try in futur... > > Would you accept git pull requests? Sure, but please als

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Stefano Lattarini
On 07/20/2012 04:42 PM, Joachim Schmitz wrote: > > First I'd need to get git ported to NonStop, this is on my todolist already. > Appare4ny git install needs Python > AFAIK, only some non-fundamental programs and features in the Git toolbox need python. Most of git is perfectly usable without pyt

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Eric Blake
On 07/20/2012 08:42 AM, Joachim Schmitz wrote: >>> Huh? 8.17 is old? It's the latest I could get and still has src/su.c. >>> Anyway, that patch isn't needed for NonStop anyway, as we need an >>> entirely different authentication method. >> >> It's removed in git, for the upcoming 8.18 release. >> W

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Joachim Schmitz
> -Original Message- > From: Jim Meyering [mailto:j...@meyering.net] > Sent: Friday, July 20, 2012 4:28 PM > To: Joachim Schmitz > Cc: 'Paul Eggert'; bug-gnulib@gnu.org; nagendra...@hp.com; > 10...@debbugs.gnu.org; 'Schmitz, Joachim'; 'Eric Blake' > Subject: Re: bug#10305: coreutils-8.14, "

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: >> However, note that you're using an old version of coreutils. In the > latest, su.c >> has been removed so you can drop the patches to that file. > > Huh? 8.17 is old? It's the latest I could get and still has src/su.c. > Anyway, that patch isn't needed for NonStop anyway,

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Joachim Schmitz
> From: Joachim Schmitz [mailto:j...@schmitz-digital.de] > Sent: Thursday, July 19, 2012 7:54 PM > After quite a few iterations and with integrating the things you already > fixed for > the next releases of gnulib, coreuitls and tar, we finally got it running > fine for > coreutils-8.15. Doing t

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Joachim Schmitz
> -Original Message- > From: Jim Meyering [mailto:j...@meyering.net] > Sent: Friday, July 20, 2012 4:07 PM > To: Joachim Schmitz > Cc: 'Paul Eggert'; bug-gnulib@gnu.org; nagendra...@hp.com; > 10...@debbugs.gnu.org; 'Schmitz, Joachim'; 'Eric Blake' > Subject: Re: bug#10305: coreutils-8.14,

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: >> From: Jim Meyering [mailto:j...@meyering.net] >> Sent: Friday, July 20, 2012 3:48 PM >> To: Joachim Schmitz >> Cc: 'Paul Eggert'; 10...@debbugs.gnu.org; bug-gnulib@gnu.org; 'Eric > Blake'; >> 'Schmitz, Joachim'; nagendra...@hp.com >> Subject: Re: bug#10305: coreutils-8.14

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: ... > I just saw that my patch removed 2 functions more than your's, mine also > removes cache_stat_ok() and is_nondir_lstat(). > Intention? Used where? Here's the patch: >From c1263bb95e8ff84e819753c9050b96d16441aa81 Mon Sep 17 00:00:00 2001 From: Joachim Schmitz Date: Fr

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Joachim Schmitz
> From: Jim Meyering [mailto:j...@meyering.net] > Sent: Friday, July 20, 2012 3:48 PM > To: Joachim Schmitz > Cc: 'Paul Eggert'; 10...@debbugs.gnu.org; bug-gnulib@gnu.org; 'Eric Blake'; > 'Schmitz, Joachim'; nagendra...@hp.com > Subject: Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF > >

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: ... > I just saw that my patch removed 2 functions more than your's, mine also > removes cache_stat_ok() and is_nondir_lstat(). > Intention? Used where? Hah! I should have temporarily defined-away "inline" to be sure I'd removed all of them -- then gcc warns about each defi

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Joachim Schmitz
> From: Jim Meyering [mailto:j...@meyering.net] > Sent: Friday, July 20, 2012 2:35 PM > To: Joachim Schmitz > Cc: 'Paul Eggert'; 10...@debbugs.gnu.org; bug-gnulib@gnu.org; 'Eric Blake'; > 'Schmitz, Joachim'; nagendra...@hp.com > Subject: Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF > >

Re: Documentation module lib-symbol-visibility

2012-07-20 Thread Michael Goffioul
On Fri, Jul 20, 2012 at 2:17 PM, Дилян Палаузов wrote: > Hello Michael, > > there is a point with dllexport/dllimport, however when not building for > Windows, the argumentation does not apply and the recommendation for use > LIBFOO_DLL_EXPORTED in the header files is suboptimal in my eyes. > Ind

Re: Documentation module lib-symbol-visibility

2012-07-20 Thread Дилян Палаузов
Hello Michael, there is a point with dllexport/dllimport, however when not building for Windows, the argumentation does not apply and the recommendation for use LIBFOO_DLL_EXPORTED in the header files is suboptimal in my eyes. Looking at the documentation of module lib-symbol-visibility, at t

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: >> From: Jim Meyering [mailto:j...@meyering.net] >> Sent: Friday, July 20, 2012 2:35 PM >> To: Joachim Schmitz >> Cc: 'Paul Eggert'; 10...@debbugs.gnu.org; bug-gnulib@gnu.org; 'Eric > Blake'; >> 'Schmitz, Joachim'; nagendra...@hp.com >> Subject: Re: bug#10305: coreutils-8.14

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Joachim Schmitz
> From: Jim Meyering [mailto:j...@meyering.net] > Sent: Friday, July 20, 2012 2:35 PM > To: Joachim Schmitz > Cc: 'Paul Eggert'; 10...@debbugs.gnu.org; bug-gnulib@gnu.org; 'Eric Blake'; > 'Schmitz, Joachim'; nagendra...@hp.com > Subject: Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF > >

Re: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread Jim Meyering
Joachim Schmitz wrote: ... > I've disable a bit of apparently dead code in src/remove.c ... > /usr/local/bin/diff -EBbu ./src/remove.c.orig ./src/remove.c > --- ./src/remove.c.orig 2012-05-01 15:55:08 -0500 > +++ ./src/remove.c2012-06-18 10:06:04 -0500 > @@ -88,6 +88,7 @@ >return st;

Re: Documentation module lib-symbol-visibility

2012-07-20 Thread Michael Goffioul
On Fri, Jul 20, 2012 at 12:56 PM, Дилян Палаузов wrote: > Defining LIBFOO_DLL_EXPORTED in public header files has no added value > from the user's perspective: mentioning a function in the public header > files implies, that the function is visible. As suggested, there is > another way to achieve

Documentation module lib-symbol-visibility

2012-07-20 Thread Дилян Палаузов
Hello, the documentation of the module lib-symbo-visibility, http://www.gnu.org/software/gnulib/manual/html_node/Exported-Symbols-of-Shared-Libraries.html, recommends defining macro LIBFOO_DLL_EXPORTED, which shall be enabled in all public header files, and annotating all variable, function an

Re: Check mc build on other OS before release.

2012-07-20 Thread Paul Eggert
On 07/12/2012 11:47 PM, Andrew Borodin wrote: > Currently mc code synced with recent fsusage module of gnulib is not compiled > on Solaris. Thanks for reporting that. I installed the following fix into the gnulib trunk. --- ChangeLog |7 +++ lib/fsusage.c |5 +++-- 2 files chang

Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code

2012-07-20 Thread Hu Tao
On Thu, Jul 19, 2012 at 08:15:28AM -0600, Eric Blake wrote: > On 07/18/2012 07:07 PM, Hu Tao wrote: > > <...> > > > >> + > >> +# define virAtomicIntGet(atomic) \ > >> +(__extension__ ({ \ > >> +

RE: bug#10305: coreutils-8.14, "rm -r" fails with EBADF

2012-07-20 Thread V S, Nagendra (Nonstop Filesystems Team)
Was doing more code study on the getcwd problem, The coreutils config.hin no more defines any of RAW_DECL_* functions, which where present in 8.15. Can we except more problems because of this? Thanks & Regards Nagendra.V.S -Original Message- From: Joachim Schmitz [mailto:j...@schmitz-di