Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-09 Thread Jim Meyering
Akim Demaille wrote: > Le 6 juil. 2012 à 14:44, Jim Meyering a écrit : >> No, but if you think it's better, somehow... >> I meant that warnf would be a very thin wrapper around printf: >> >>$ printf '%s\n' a b c >>a >>b >>c >> >>> Or should warnf expect a single %s >> >> or multiple

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-09 Thread Eric Blake
On 07/09/2012 05:04 PM, Eric Blake wrote: >> -warn() >> +# warnf_ FORMAT-STRING ARG1... >> +warnf_ () >> { >> - for i >> - do >> -echo "$i" >> - done | sed -e "s/^/$me: /" >&2 > > This is broken if you invoke './bootstrap', since then $me contains / > and bootstrap complains: > > autorec

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

2012-07-09 Thread Eric Blake
On 07/06/2012 07:11 AM, Akim Demaille wrote: > How about this? > > From 96b829fb08217060f20a6a56eddb1a952324fa35 Mon Sep 17 00:00:00 2001 > From: Akim Demaille > Date: Fri, 6 Jul 2012 15:01:53 +0200 > Subject: [PATCH] bootstrap: let warn be alike tests/init.sh's warn_ > > Reported by Jim Meyeri

Re: -Winline generates warnings against gnulib code

2012-07-09 Thread Paul Eggert
On 07/09/2012 02:54 PM, Reuben Thomas wrote: > So should -Winline be removed from the standard set for the > manywarnings module? I'd favor that. Also, -Wunsafe-loop-optimizations. In normal usage these are not about programming errors or questionable usages, but are merely messages from the dept

Re: -Winline generates warnings against gnulib code

2012-07-09 Thread Reuben Thomas
On 9 July 2012 16:03, Bruno Haible wrote: > Reuben Thomas wrote: >> Compiling with -Winline, I get warnings like this: >> >> src/main.c: In function 'main': >> ./lib/gl_xlist.h:124:1: warning: inlining failed in call to >> 'gl_list_add_last_inline': call is unlikely and code size would grow > > Fo

Re: [PATCH] getloadavg, getopt: fix commentary re configure.in

2012-07-09 Thread Bruno Haible
Paul Eggert wrote: > Yes, thanks, that works -- I just now checked with the > Emacs trunk. Thanks for checking. I've now pushed the change. Bruno

[PATCH] maint.mk: add sc_vulnerable_makefile_CVE-2012-3386

2012-07-09 Thread Jim Meyering
To accompany automake's just-fixed "make distcheck" vulnerability, http://thread.gmane.org/gmane.comp.sysutils.automake.patches/8572 here's a syntax-check rule like the one for CVE-2009-4029: >From 48fe477c9008efadab8cf8c0c3240d824c12a8b9 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mo

Re: ifdef HAVE_DECL_

2012-07-09 Thread Eric Blake
[adding gnulib] On 06/13/2012 03:45 AM, Karel Zak wrote: > On Wed, Jun 13, 2012 at 11:32:33AM +0200, Karel Zak wrote: > >> More complex (and I hope without false positives) solution: > > well... ;-) > >> >> for decl in $(awk '/define HAVE_DECL_.*ac_have_decl/ { print $2 }' >> configure);

Re: [PATCH] getloadavg, getopt: fix commentary re configure.in

2012-07-09 Thread Paul Eggert
On 07/09/2012 07:51 AM, Bruno Haible wrote: > So, can we simplify getopt.m4 accordingly? How about this patch? Yes, thanks, that works -- I just now checked with the Emacs trunk.

compilation failure against installed libuninstring 0.9.1

2012-07-09 Thread Andy Wingo
Hi, Guile updated its Gnulib checkout to v0.0-7509-g98a2286 before releasing. We use the "libunistring" module to check for installed libunistring. However, this revision of Gnulib does not compile against installed libunistring 0.9.1. Users are reporting errors like: In file included from

Re: -Winline generates warnings against gnulib code

2012-07-09 Thread Bruno Haible
Reuben Thomas wrote: > Compiling with -Winline, I get warnings like this: > > src/main.c: In function 'main': > ./lib/gl_xlist.h:124:1: warning: inlining failed in call to > 'gl_list_add_last_inline': call is unlikely and code size would grow Formally, this looks like a warning. Semantically, it

Re: [PATCH] getloadavg, getopt: fix commentary re configure.in

2012-07-09 Thread Bruno Haible
Hi Paul, > + * m4/getopt.m4 (gl_GETOPT_IFELSE, gl_GETOPT_SUBSTITUTE_HEADER) > + (gl_PREREQ_GETOPT): Remove obsolete commentary re Emacs configure.in. > + Emacs has renamed it to configure.ac, and it no longer refers > + to these macros anyway. So, can we simplify getopt.m4 accordi

[PATCH] maint.mk: _sc_search_regexp, sc_vulnerable_makefile_CVE-2009-4029: fix

2012-07-09 Thread Jim Meyering
I noticed that the CVE-2009-4029-detecting rule wasn't working. Surprised to find that *two* bugs were behind the failure. >From b38d59184505f6119a5ffbf3b4a068fd7a9b8fe8 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 9 Jul 2012 16:11:34 +0200 Subject: [PATCH] maint.mk: _sc_search_regexp,

Re: add --match argument to git-version-gen

2012-07-09 Thread Eric Blake
On 07/07/2012 02:42 PM, Jim Meyering wrote: >> +function massage_git_version() { >> +local v=$1 > > Using the "function" and "local" keywords would make this script > fail for some older shells. I'd like to remain portable to those. Not just older shells. POSIX does not require either 'fun

[PATCH] getloadavg, getopt: fix commentary re configure.in

2012-07-09 Thread Paul Eggert
ChangeLog|9 + lib/getloadavg.c |2 +- m4/getopt.m4 |3 --- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6618aa8..c0ebb3e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,14 @@ 2012-07-09 Paul Eggert + getl

[PATCH] timespec: mark functions with const attributes

2012-07-09 Thread Paul Eggert
ChangeLog |6 ++ lib/timespec.h |9 ++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index ce24403..6618aa8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2012-07-09 Paul Eggert + + timespec: mark functions with cons