Re: -Winline generates warnings against gnulib code

2012-07-08 Thread Paul Eggert
On 07/08/2012 05:32 PM, Reuben Thomas wrote: > I'm not (intentionally) assuming that I'm using gcc; can I do > this more portably? Here's what Emacs does for a similar situation: at configure-time it sees whether it's using GCC and is being asked to compile with diagnostics turned on, and if so it

Re: -Winline generates warnings against gnulib code

2012-07-08 Thread Reuben Thomas
On 9 July 2012 01:19, Paul Eggert wrote: > On 07/08/2012 05:12 PM, Reuben Thomas wrote: >> surely gnulib should be treated as system >> headers, and -Winline give no warnings. Is there a way to make this >> happen? > > With GCC you can use -isystem, rather than -I, to include > the gnulib headers.

Re: -Winline generates warnings against gnulib code

2012-07-08 Thread Paul Eggert
On 07/08/2012 05:12 PM, Reuben Thomas wrote: > surely gnulib should be treated as system > headers, and -Winline give no warnings. Is there a way to make this > happen? With GCC you can use -isystem, rather than -I, to include the gnulib headers.

-Winline generates warnings against gnulib code

2012-07-08 Thread Reuben Thomas
Compiling with -Winline, I get warnings like this: src/main.c: In function 'main': ./lib/gl_xlist.h:124:1: warning: inlining failed in call to 'gl_list_add_last_inline': call is unlikely and code size would grow [-Winline] src/main.c:174:35: warning: called from here [-Winline] ./lib/gl_xlist.h:12

Re: [PATCH 2/2] canonicalize[-lgpl]: properly handle "guessing" values when cross-building

2012-07-08 Thread Ludovic Courtès
Thanks, Ludo’.

Re: [PATCH 1/2] canonicalize: make the right guess when cross-compiling to GNU

2012-07-08 Thread Ludovic Courtès
Bruno Haible skribis: >> canonicalize: make the right guess when cross-compiling to GNU > > By the way, there are many more cross-compilation guesses in gnulib. > If you want to have them support GNU/Hurd, Note that most of the time, libc features are the same on *-gnu and gnu*. > the w

Re: [PATCH 1/2] canonicalize: make the right guess when cross-compiling to GNU

2012-07-08 Thread Ludovic Courtès
Hi Bruno, Bruno Haible skribis: > Hi Ludo, > >> [case "$host_os" in >> # Guess yes on glibc systems. >> -*-gnu*) gl_cv_func_realpath_works="guessing yes" ;; >> +*gnu*) gl_cv_func_realpath_works="guessing yes" ;; >> # If we don't know, assu

Re: [libvirt] namespace clean shared libraries

2012-07-08 Thread Bruno Haible
Daniel P. Berrange wrote: > If its better to just do it in libvirt config.h, then we > can do that too Yes, doing '#define foo libvirt_foo' in config.h is the preferred way of achieving a namespace clean shared library. There are two ways to generate these #defines: 1) You collect manually, on v

Re: ./m4/pthread.m4 causes coreutils build failure on FreeBSD 9

2012-07-08 Thread Bruno Haible
Hi Paul, > I coded up and pushed the following patch, can you please > give it a try? It works on Fedora 15 and Solaris 10, but I > haven't tested it on other platforms. Thanks. It works fine also on OSF/1 5.1 and IRIX 6.5 (among others). Bruno

Re: [PATCH 1/2] canonicalize: make the right guess when cross-compiling to GNU

2012-07-08 Thread Bruno Haible
> canonicalize: make the right guess when cross-compiling to GNU By the way, there are many more cross-compilation guesses in gnulib. If you want to have them support GNU/Hurd, the way to do so is to send us the configure output. config.log file, and config.cache file of a *native* build o

Re: [PATCH 2/2] canonicalize[-lgpl]: properly handle "guessing" values when cross-building

2012-07-08 Thread Bruno Haible
Ludovic Courtès wrote: > + canonicalize[-lgpl]: properly handle "guessing" values when > cross-building > + * m4/canonicalize.m4 (gl_FUNC_CANONICALIZE_FILENAME_MODE) > + (gl_CANONICALIZE_LGPL): Check whether $gl_cv_func_realpath_works > + matches "*yes" instead of just "yes". Regr

Re: [PATCH 1/2] canonicalize: make the right guess when cross-compiling to GNU

2012-07-08 Thread Bruno Haible
Hi Ludo, > [case "$host_os" in > # Guess yes on glibc systems. > -*-gnu*) gl_cv_func_realpath_works="guessing yes" ;; > +*gnu*) gl_cv_func_realpath_works="guessing yes" ;; > # If we don't know, assume the worst. > *) gl_cv_func