Re: update-copyright request and patch...

Joel Brobecker writes: >> > Yep, this is what we did for this year. I just want to go one step >> > further and just collapse all years into one single range, based on >> > the fact that I have verified that we have made significant changes >> > to at least one file each year since 1986. >> >> I

Re: sys/types.h on Android includes stdint.h before defining time_t

Hans-Christoph Steiner writes: > On 01/26/2012 03:59 PM, Paul Eggert wrote: >> On 01/26/2012 12:14 PM, Hans-Christoph Steiner wrote: >>> ./stdint.h:32:3: error: invalid preprocessing directive #@ >> >> This looks like some sort of problem in the way the patch >> was applied. Perhaps you need to

Re: update-copyright request and patch...

> > Yep, this is what we did for this year. I just want to go one step > > further and just collapse all years into one single range, based on > > the fact that I have verified that we have made significant changes > > to at least one file each year since 1986. > > I have already done this for som

Re: locale_charset() on MacOS X

Paul Eggert reported: > . Akim Demaille wrote: > I'm sending this message to you as the main author of > the quotearg module. I am not sure which component should > be considered guilty here, but the problem is: > > - independent

Re: test-stdalign.c breaks on i686 on Fedora Rawhide (gcc 4.7)

Richard W.M. Jones wrote: > CC test-stdalign.o Please, can you show the entire compiler command? Run "make V=1" so that 'make' prints the real command. > Compiler and kernel version: > > gcc-4.7.0-0.9.fc17.i686 > Linux fedorarawhidex32 2.6.38.6-27.fc15.i686.PAE #1 SMP Sun May 15 17:39:

test-stdalign.c breaks on i686 on Fedora Rawhide (gcc 4.7)

CC test-stdalign.o test-stdalign.c:70:1: error: static assertion failed: "verify (alignof (int64_t) == offsetof (int64_t_helper, slot2))" test-stdalign.c:73:1: error: static assertion failed: "verify (alignof (double) == offsetof (double_helper, slot2))" make[4]: *** [test-stdalign.o] Error

Re: sys/types.h on Android includes stdint.h before defining time_t

On 01/26/2012 03:59 PM, Paul Eggert wrote: > On 01/26/2012 12:14 PM, Hans-Christoph Steiner wrote: >> ./stdint.h:32:3: error: invalid preprocessing directive #@ > > This looks like some sort of problem in the way the patch > was applied. Perhaps you need to re-run gnulib-tool, > or ./bootstrap,

Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib

Le 25 janv. 2012 à 20:33, Paul Eggert a écrit : > Does the following gnulib patch fix things for Bison on OS X? > I'll CC: this to bug-gnulib@gnu.org, to give Bruno Haible > a heads-up about the localcharset problem. Hi Paul, Yes, that does fix the failures, thanks!

Re: [PATCH] pipe2: document lack of thread-safety in replacement

Eric Blake wrote: > > -But the replacement function is not atomic in multi-threaded programs. > > +But the replacement function is not atomic; this matters in multi-threaded > > +programs that spawn child processes. > > I like it. Thanks for the review. I've pushed it. Bruno

Re: sys/types.h on Android includes stdint.h before defining time_t

On 01/26/2012 12:14 PM, Hans-Christoph Steiner wrote: > ./stdint.h:32:3: error: invalid preprocessing directive #@ This looks like some sort of problem in the way the patch was applied. Perhaps you need to re-run gnulib-tool, or ./bootstrap, or ./autogen.sh, or whatever-it-is-with your package, t

Re: [PATCH] pipe2: document lack of thread-safety in replacement

On 01/26/2012 12:26 PM, Eric Wong wrote: > I can't think of a safe way to implement > SOCK_CLOEXEC/SOCK_NONBLOCK/O_CLOEXEC as-is in gnulib and have it be > forward-compatible. If we expose the flags in public headers, the OS > authors can eventually add support for these things and the native OS >

Re: sys/types.h on Android includes stdint.h before defining time_t

On 01/23/2012 04:04 AM, Simon Josefsson wrote: > Bruno Haible writes: > >> 2) Change stdint.h to just include the system's when >>__BIONIC__ and _SYS_TYPES_H_ are defined but _SSIZE_T_DEFINED_ is not >>yet defined. >> >> The latter is simpler (does not require to override sys/types.h),

Re: [PATCH] pipe2: document lack of thread-safety in replacement

Eric Blake wrote: > On 01/25/2012 06:09 PM, Eric Wong wrote: > > As the replacement cannot be made thread-safe, we need to > > document this to prevent users from having a false sense > > of safety. > > > > * doc/glibc-functions/pipe2.texi (pipe2): mention lack of thread-safety > > > > Signed-of

Re: [PATCH] pipe2: document lack of thread-safety in replacement

On 01/26/2012 10:07 AM, Bruno Haible wrote: > Eric Blake wrote: >> Thread one calls pipe2(O_CLOEXEC), but gets the gnulib version, which >> first calls pipe(), then we context switch. >> Thread two calls fork(), and in the child, calls exec() > > Right, this is why pipe2 should better be atomic. >

Re: posix_spawn_file_actions_addclose on Solaris 11

While fixing this test failure on Solaris 11: > > test-posix_spawn_file_actions_addopen.c:49: assertion failed > FAIL: test-posix_spawn_file_actions_addopen I introduced this configure message on a glibc system: checking whether posix_spawn_file_actions_addopen works... no

Re: [PATCH] pipe2: document lack of thread-safety in replacement

Eric Blake wrote: > Thread one calls pipe2(O_CLOEXEC), but gets the gnulib version, which > first calls pipe(), then we context switch. > Thread two calls fork(), and in the child, calls exec() Right, this is why pipe2 should better be atomic. But this goes beyond of what is normally understood b

Re: [libvirt] [PATCH libvirt 6/6] Cast timeval.tv_sec long to localtime expected type time_t

On Thu, Jan 26, 2012 at 3:01 PM, Bruno Haible wrote: > Eric Blake wrote: >> <_timeval.h>: >> struct timeval >> { >>         long tv_sec; >>         long tv_usec; >> }; >> >> Oops.  struct timeval is generating a struct timeval with a 32-bit >> tv_sec even when time_t is 64-bits. > > mingw64 is sti

Re: [PATCH] pipe2: document lack of thread-safety in replacement

On 01/25/2012 06:09 PM, Eric Wong wrote: > As the replacement cannot be made thread-safe, we need to > document this to prevent users from having a false sense > of safety. > > * doc/glibc-functions/pipe2.texi (pipe2): mention lack of thread-safety > > Signed-off-by: Eric Wong > --- > I took th

Re: [PATCH] pipe2: document lack of thread-safety in replacement

On 01/26/2012 07:28 AM, Bruno Haible wrote: > Eric Wong wrote: >> As the replacement cannot be made thread-safe, we need to >> document this to prevent users from having a false sense >> of safety. >> >> * doc/glibc-functions/pipe2.texi (pipe2): mention lack of thread-safety > > Can you please des

Re: [PATCH] pipe2: document lack of thread-safety in replacement

Eric Wong wrote: > As the replacement cannot be made thread-safe, we need to > document this to prevent users from having a false sense > of safety. > > * doc/glibc-functions/pipe2.texi (pipe2): mention lack of thread-safety Can you please describe a situation with multiple threads where gnulib's

Re: [libvirt] [PATCH libvirt 6/6] Cast timeval.tv_sec long to localtime expected type time_t

Eric Blake wrote: > <_timeval.h>: > struct timeval > { > long tv_sec; > long tv_usec; > }; > > Oops. struct timeval is generating a struct timeval with a 32-bit > tv_sec even when time_t is 64-bits. mingw64 is still in development. Please, Marc-André, can you work with them, upst