[PATCH] test-getcwd: disambiguate exit status

test-getcwd: disambiguate exit status * tests/test-getcwd.c (test_long_name): Return 0..7. (main): Exit with an unambiguous exit status. The old code yielded a mysterious mixture of two failure codes. diff --git a/tests/test-getcwd.c b/tests/test-getcwd.c index e9832f0..359aedb 100644 --- a/tests/

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

Thanks for the further details about the problem. On 11/18/11 14:54, Mats Erik Andersson wrote: > # if ! HAVE_WORKING_FSTATAT_ZERO_FLAG > # define AT_FUNC_NAME rpl_fstatat > # else > # define AT_FUNC_NAME fstatat > # endif > > ... This is probably broken. Right you are. The macro should depen

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

Dear Paul, fredag den 18 november 2011 klockan 12:52 skrev Paul Eggert detta: > On 11/18/11 12:07, Mats Erik Andersson wrote: > > > The [fstatat] module is built, but not automatically included in "libgnu.a". > > OK, thanks. Now we need to find out why that problem is happening. Recently Bruno

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

On 11/18/11 12:07, Mats Erik Andersson wrote: > The [fstatat] module is built, but not automatically included in "libgnu.a". OK, thanks. Now we need to find out why that problem is happening. The fstatat module lists this in its configure.ac section: gl_FUNC_FSTATAT if test $HAVE_FSTATAT = 0 ||

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

Dear Paul, fredag den 18 november 2011 klockan 10:23 skrev Paul Eggert detta: > On 11/18/11 02:25, Mats Erik Andersson wrote: > > I will back track the failure more > > Thanks. > > A similar problem was recently reported for octave on mingw; see >

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

On 11/18/11 02:25, Mats Erik Andersson wrote: > I will back track the failure more Thanks. A similar problem was recently reported for octave on mingw; see . That bug report had a bit more information, enough so that I committe

Re: [PATCH] hash: deprecate poorly-named hash_insert0: use hash_insert_if_absent

Jim Meyering wrote: > Jim Meyering wrote: > >> Here's a proposed change to rename/deprecate a function in hash.c that >> was so poorly named (by me!) that it was harder than necessary to use. >> AFAICS (google, codesearch), the only existing use is in di-set.c, >> and I've adjusted that. >> >> Whi

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

Bruno Haible wrote: > Jim Meyering wrote: >> +static inline int >> +ctime_compare (struct stat const *a, struct stat const *b) > > This code uses 'inline'. But the module descriptions > modules/fdutimensat-tests > modules/futimens-tests > modules/utimens-tests > modules/utimensat-tests > d

Re: [PATCH] tests: factor st_ctime-comparison out of two headers

Jim Meyering wrote: > +static inline int > +ctime_compare (struct stat const *a, struct stat const *b) This code uses 'inline'. But the module descriptions modules/fdutimensat-tests modules/futimens-tests modules/utimens-tests modules/utimensat-tests don't contain an AC_REQUIRE([AC_C_INLIN

Re: Problem compiling latest gnulib on Solaris 9 i386 with Sun Studio

Dagobert Michelsen wrote: > I just tried to build a static gnulib as described in > > http://www.gnu.org/software/gnulib/manual/html_node/POSIX-Substitutes-Library.html#POSIX-Substitutes-Library > on Solaris 9 i386 with Sun Studio 12 and got the following error: > > source='openat.c' object='ope

Problem compiling latest gnulib on Solaris 9 i386 with Sun Studio

Hi, I just tried to build a static gnulib as described in http://www.gnu.org/software/gnulib/manual/html_node/POSIX-Substitutes-Library.html#POSIX-Substitutes-Library on Solaris 9 i386 with Sun Studio 12 and got the following error: source='openat.c' object='openat.o' libtool=no \ DEPDIR=.deps

Re: [PATCH] hash: deprecate poorly-named hash_insert0: use hash_insert_if_absent

Jim Meyering wrote: > Here's a proposed change to rename/deprecate a function in hash.c that > was so poorly named (by me!) that it was harder than necessary to use. > AFAICS (google, codesearch), the only existing use is in di-set.c, > and I've adjusted that. > > While I've deprecated the offendi

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

Mats Erik Andersson wrote: > torsdag den 17 november 2011 klockan 22:02 skrev Paul Eggert detta: >> On 11/17/11 13:51, Mats Erik Andersson wrote: >> > Why is your code not falling back to the native getcwd()? >> >> Presumably the OpenBSD getcwd has some sort of >> incompatibility or bug, and gnulib

[PATCH] hash: deprecate poorly-named hash_insert0: use hash_insert_if_absent

Here's a proposed change to rename/deprecate a function in hash.c that was so poorly named (by me!) that it was harder than necessary to use. AFAICS (google, codesearch), the only existing use is in di-set.c, and I've adjusted that. While I've deprecated the offending function, hash_insert0, given

Re: libgnu: rpl_getcwd broken on OpenBSD 4.6

torsdag den 17 november 2011 klockan 22:02 skrev Paul Eggert detta: > On 11/17/11 13:51, Mats Erik Andersson wrote: > > Why is your code not falling back to the native getcwd()? > > Presumably the OpenBSD getcwd has some sort of > incompatibility or bug, and gnulib's trying to work around it. > Wi