Re: exclude tests refactoring

2011-11-13 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, > >> Thanks for testing and noticing that. >> However, I would like to avoid using a temporary file when using GNU diff. >> How about something like this instead? >> >> diff_=$(diff -u "$0" "$0" < /dev/null 2> /dev/null) >> if test $? = 0; then >> if test -z "$diff_"

Re: exclude tests refactoring

2011-11-13 Thread Bruno Haible
Hi Jim, > Thanks for testing and noticing that. > However, I would like to avoid using a temporary file when using GNU diff. > How about something like this instead? > > diff_=$(diff -u "$0" "$0" < /dev/null 2> /dev/null) > if test $? = 0; then > if test -z "$diff_"; then > compare () { dif

indentation in Makefile

2011-11-13 Thread Bruno Haible
Apparently GNU make works also with spaces instead of tabs in continuation lines of rule commands? But nevertheless it's more consistent to use tabs here for indentation. 2011-11-13 Bruno Haible Makefile: Tweak indentation. * Makefile: Use tab as first character in every line

Re: gnulib copyright method

2011-11-13 Thread Bruno Haible
Karl Berry wrote: > As I recall, this situation came about to placate projects which were > using gnulib without using gnulib-tool, notably coreutils and others > that Paul E and Jim M were working on. In the years since then, all > those projects (to my knowledge) have started using gnulib-tool.

Re: git-version-gen

2011-11-13 Thread Simon Josefsson
Simon Josefsson writes: > How about this patch to make the match string configurable? That was broken, I pushed a better one that should have less backwards compatibility issues (I hope). /Simon diff --git a/ChangeLog b/ChangeLog index 13248fc..b6bf5b2 100644 --- a/ChangeLog +++ b/ChangeLog @@

Re: git-version-gen

2011-11-13 Thread Simon Josefsson
How about this patch to make the match string configurable? /Simon diff --git a/build-aux/git-version-gen b/build-aux/git-version-gen index 3234bdd..1d484d9 100755 --- a/build-aux/git-version-gen +++ b/build-aux/git-version-gen @@ -1,6 +1,6 @@ #!/bin/sh # Print a version string. -scriptversion=

Re: gnulib copyright method

2011-11-13 Thread Simon Josefsson
k...@freefriends.org (Karl Berry) writes: > So how about normalizing gnulib to have the actual license in the source > files? +1 This has caused several misunderstandings and I've always hoped we could return to normal practices here. /Simon

Re: git-version-gen

2011-11-13 Thread Simon Josefsson
Eric Blake writes: > On 11/12/2011 11:53 AM, Simon Josefsson wrote: >> For inetutils (which uses git tags looking like 'inetutils-1_8') we >> noticed that git-version-gen hardcodes an expression when searching for >> particular tags: >> >> && v=`git describe --abbrev=4 --match='v*' HEAD 2>/d