Re: split off module fstatat from module openat

> 2011-11-03 Bruno Haible > > New module 'fstatat', split off from module 'openat'. Oops, this patch was incomplete. A megatestdir of the various *at modules revealed a link error in test-unlinkat on Solaris 9. This should fix it. 2011-11-04 Bruno Haible fchownat, renameat,

openpty needs a variant with a flags argument

openpty is worthless in a multithreaded app like libvirt - there's no way to make the master and slave fds atomically O_CLOEXEC; libvirt would also like O_NONBLOCK (although atomicity on that one is not as important); yet not using openpty() is also painful because of the need for ioctl() on So

Re: split off module mkdirat from module openat

On 11/04/11 03:54, Bruno Haible wrote: > - openat uses lib/at-func.c, which includes , thus requires module > 'dirent'. Thanks for all that work. This particular change prompted me to look into why at-func.c includes dirent.h via openat.h, and this inclusion appears to be no longer needed,

Re: split off module mkdirat from module openat

Bruno Haible wrote: > This patch is tested on a dozen of platforms as well, like the other ones. > > Here's a proposed fixup for some small omissions in the module descriptions. > - fchmodat, fchownat, linkat, renameat use lib/at-func.c or lib/at-func2.c > which requires openat_save_fail from

[PATCH] at-func*.c: fix comments

FYI, >From 6a72f73905064a64091d16fd0787b96a012b4794 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 4 Nov 2011 13:33:54 +0100 Subject: [PATCH] at-func*.c: fix comments * lib/at-func2.c: Correct/improve first-line comment. * lib/at-func.c: Correct grammar in first-line comment. --- Change

Re: split off module mkdirat from module openat

Jim Meyering wrote: > Looks fine. Push away. I've pushed it. Bruno -- In memoriam Yitzhak Rabin

closedir: avoid warning

On mingw, I'm seeing this gcc warning: closedir.c: In function `rpl_closedir': closedir.c:60: warning: implicit declaration of function `_gl_unregister_fd' This fixes it. 2011-11-04 Bruno Haible closedir: Avoid warning on mingw. * lib/closedir.c: Include . *** lib/closedir.

Re: split off module mkdirat from module openat

> This proposed patch splits off module mkdirat from module openat. This patch is tested on a dozen of platforms as well, like the other ones. Here's a proposed fixup for some small omissions in the module descriptions. - fchmodat, fchownat, linkat, renameat use lib/at-func.c or lib/at-func2.c

Re: split off module mkdirat from module openat

Bruno Haible wrote: > This proposed patch splits off module mkdirat from module openat. > > 2011-11-04 Bruno Haible > > New module 'mkdirat', split off from module 'openat'. > * m4/mkdirat.m4: New file. extracted from m4/openat.m4. > * m4/openat.m4 (gl_FUNC_OPENAT): Don't requi

split off module mkdirat from module openat

Hi Jim, This proposed patch splits off module mkdirat from module openat. 2011-11-04 Bruno Haible New module 'mkdirat', split off from module 'openat'. * m4/mkdirat.m4: New file. extracted from m4/openat.m4. * m4/openat.m4 (gl_FUNC_OPENAT): Don't require gl_SYS_STAT_H

Re: split off module fstatat from module openat

Jim Meyering wrote: > I've reviewed this change-set in isolation, and it looks fine. I've pushed it now. Bruno -- In memoriam Yitzhak Rabin

Re: split off module fstatat from module openat

Bruno Haible wrote: > The next split-off is 'fstatat'. Here's the proposed patch. Tested on several > platforms. > > 2011-11-03 Bruno Haible > > New module 'fstatat', split off from module 'openat'. > * lib/openat.h (statat, lstatat): Enable only if GNULIB_FSTATAT is > defined.