Re: opendir.c: In function 'rpl_opendir': error: 'errno' undeclared (first use in this function)

2011-09-14 Thread Tatsuro MATSUOKA
Hello With this fix I was successfully able to compile opendir.c. Thanks! Tatsuro --- Eric Blake wrote: > On 09/13/2011 09:42 PM, Tatsuro MATSUOKA wrote: > > Hello > > > > I am one of the build tester of GNU octave. The GNU octave uses the > gnulib. > > After I have pulled the git components,

Re: m4 brackets question

2011-09-14 Thread Bruno Haible
Eric Blake wrote: > > Which of the following code lines should be changed, for maintainability? > > > >absolute-header.m4:87: s#^/[^/]#//&# > > Underquoted. I'd recommend using | instead of # in the sed snippet Yes, this will be clearer. Thanks for the advice. > >csharpcomp.m4:15:

Re: m4 brackets question

2011-09-14 Thread Bruno Haible
Eric Blake wrote: > > Underquoted (and autoconf has magic in AC_CHECK_DECL that tries to deal > > with the underquoting, since this is so common), since the fourth > > argument of AC_CHECK_DECL is supposed to allow further m4 macro > > expansion when used properly. The same apparently holds for

Re: m4 brackets question

2011-09-14 Thread Bruno Haible
Eric Blake wrote: > Underquoted (and autoconf has magic in AC_CHECK_DECL that tries to deal > with the underquoting, since this is so common), since the fourth > argument of AC_CHECK_DECL is supposed to allow further m4 macro > expansion when used properly. Should be: > > AC_CHECK_DECL([tanl],

Re: maint.mk syntax check problems

2011-09-14 Thread Simon Josefsson
Martin von Gagern writes: > Re-sending for the mailing list, forgot that a moment ago. > > On 14.09.2011 16:49, Simon Josefsson wrote: >> I'm not a fan of separate shell scripts, each new file to deal with >> seems to incur a small maintainance cost over time -- consider when they >> are renamed

Re: maint.mk syntax check problems

2011-09-14 Thread Martin von Gagern
Re-sending for the mailing list, forgot that a moment ago. On 14.09.2011 16:49, Simon Josefsson wrote: > I'm not a fan of separate shell scripts, each new file to deal with > seems to incur a small maintainance cost over time -- consider when they > are renamed or moved. I think gnulib already in

Re: maint.mk syntax check problems

2011-09-14 Thread Simon Josefsson
Martin von Gagern writes: > And I'm still interested in some feedback what you think about turning > those syntax checks into a shell script file instead of embedding so > much ugly backslash-continued shell code into the makefile. I'm not a fan of separate shell scripts, each new file to deal w

Re: opendir.c: In function 'rpl_opendir': error: 'errno' undeclared (first use in this function)

2011-09-14 Thread Eric Blake
On 09/13/2011 09:42 PM, Tatsuro MATSUOKA wrote: > Hello > > I am one of the build tester of GNU octave. The GNU octave uses the gnulib. > After I have pulled the git components, I have met compile error of > opendir.c in gnulib components. > > ../../../hg/octave-work/libgnu/opendir.c: In functio

opendir.c: In function 'rpl_opendir': error: 'errno' undeclared (first use in this function)

2011-09-14 Thread Tatsuro MATSUOKA
Hello I am one of the build tester of GNU octave. The GNU octave uses the gnulib. After I have pulled the git components, I have met compile error of opendir.c in gnulib components. libtool: compile: gcc -shared-libgcc -DHAVE_CONFIG_H -I. -I../../../hg/octave-work/libgnu -I.. -I/c/Programs/gplib

Re: maint.mk syntax check problems

2011-09-14 Thread Jim Meyering
Martin von Gagern wrote: ... 5. sc_prohibit_always-defined_macros reports missing files: The sc_prohibit_always-defined_macros check will cause error messages about missing files to be emitted if elements from the gl_other_headers_ list are not present (i.e. not imported).

Re: maint.mk syntax check problems

2011-09-14 Thread Martin von Gagern
Thanks, Jim, for the swift reply this time! On 14.09.2011 14:49, Jim Meyering wrote: >>> 1. main.mk fails its own checks: >>> >>> The checks sc_makefile_at_at_check and sc_prohibit_undesirable_word_seq >>> both fail for me, as the maint.mk file itself violates these checks. >>> >>> I know, this wi

Re: maint.mk syntax check problems

2011-09-14 Thread Jim Meyering
Martin von Gagern wrote: > I recently wrote a mail with various remarks about how maint.mk syntax > checks give false positives, and some suggestions to avoid these. Bruno > Haible was kind enough to voice an opinion on items 2 and 3 of that > list, but I have seen no reply to any of the other prob

Re: maint.mk syntax check problems

2011-09-14 Thread Martin von Gagern
Hi! I recently wrote a mail with various remarks about how maint.mk syntax checks give false positives, and some suggestions to avoid these. Bruno Haible was kind enough to voice an opinion on items 2 and 3 of that list, but I have seen no reply to any of the other problems. And I'm still interes

Re: maint.mk syntax check problems

2011-09-14 Thread Martin von Gagern
Hi Bruno, thanks for your reply! On 05.09.2011 21:45, Bruno Haible wrote: > I don't think it makes sense to run such stylistic checks on files that > are not under your control. po/Makefile.in.in is owned by the gettext > maintainer, and the *.po files are in the hands of the translators. > In ot

Re: _STRING_ARCH_unaligned

2011-09-14 Thread Loïc Le Loarer
2011/9/14 Paul Eggert : > On 09/13/11 15:15, Loïc Le Loarer wrote: > >> I'm looking where _STRING_ARCH_unaligned define is defined in gnulib >> and in which condition it is set to 0. > > gnulib never defines it to anything, so any test that looks like this: > > #if !_STRING_ARCH_unaligned > > is tr

Re: m4 brackets question

2011-09-14 Thread Stefano Lattarini
On Tuesday 13 September 2011, Eric Blake wrote: > On 09/13/2011 03:09 PM, Bruno Haible wrote: > > Please, can you turn off these "m4 comments" for Autoconf 3.0? > > You can turn them off yourself with m4_changecom(). > Or use the `@%:@' quadrigraph instead of a literal `#'. I've found that this i