make -q and maintainer-makefile issues?

2011-08-10 Thread Simon Josefsson
A user reported that 'make -q' didn't work: http://permalink.gmane.org/gmane.comp.gnu.libidn.general/329 and I cannot seem to debug this properly. I suspect it has something to do with gnulib's GNUmakefile/maint.mk/cfg.mk, since coreutils 8.12 (as an example of another project using gnulib that

Re: Bug in base64, new module base32

2011-08-10 Thread Bruno Haible
Hi Gijs, > I need a base32 encoding/decoding module, but Gnulib doesn't have one. In > patch 2, I included a new module based on the base64 code that is > already in Gnulib. Your code is in line with gnulib coding style and conventions. Just one question: > + * See also RFC 3548

Re: Bug in base64, new module base32

2011-08-10 Thread Jim Meyering
Gijs van Tulder wrote: > Paul Eggert wrote: >> Thanks for the base64 bug report and patch; I applied it, > > Thanks. (That's quick!) > >> As for the base32 part, would you be willing to assign the >> copyright to the Free Software Foundation, so that we could >> install it in gnulib? > > Certainly

Re: Bug in base64, new module base32

2011-08-10 Thread Gijs van Tulder
Paul Eggert wrote: Thanks for the base64 bug report and patch; I applied it, Thanks. (That's quick!) As for the base32 part, would you be willing to assign the copyright to the Free Software Foundation, so that we could install it in gnulib? Certainly. How do I do that? Gijs

Re: Bug in base64, new module base32

2011-08-10 Thread Paul Eggert
Thanks for the base64 bug report and patch; I applied it, adding a bit to the comment; see: http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=08c11765d4fe790403229496a8a3ec625a3ca5af As for the base32 part, would you be willing to assign the copyright to the Free Software Foundation, so that

Bug in base64, new module base32

2011-08-10 Thread Gijs van Tulder
Hi, I'd like to send you two patches that are related to the base64 module. I hope you find them useful. -- The first patch fixes a bug (or at least, I think it is a bug) in the base64_decode_alloc_ctx function. This method sometimes does not decode the final byte in the input. Strange enou

[PATCH] closein: correct comments

2011-08-10 Thread Eric Blake
* lib/closein.c (close_stdin): Improve comments. Signed-off-by: Eric Blake --- I noticed this while auditing to see which modules might have been affected by the recently-fixed fseeko bug. ChangeLog |5 + lib/closein.c |5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-)