[PATCH 17/19] xstrtol: use stdnoreturn.h

* lib/xstrtol.h: Include . (_GL_ATTRIBUTE_NORETURN): Remove; all uses replaced with noreturn. * modules/xstrtol (Depends-on): Add stdnoreturn. --- ChangeLog |5 + lib/xstrtol.h | 13 - modules/xstrtol |1 + 3 files changed, 10 insertions(+), 9 deletions(-) diff -

[PATCH 14/19] openat: use stdnoreturn.h

* lib/openat.h: Include . (_GL_ATTRIBUTE_NORETURN): Remove; all uses replaced with noreturn. * modules/openat (Depends-on): Add stdnoreturn. --- ChangeLog |5 + lib/openat.h | 11 +++ modules/openat |1 + 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/C

[PATCH 18/19] xalloc: use stdnoreturn.h

* lib/xalloc.h: Include . (_GL_ATTRIBUTE_NORETURN): Remove; all uses replaced with noreturn. * modules/xalloc (Depends-on): Add stdnoreturn. --- ChangeLog |5 + lib/xalloc.h |9 ++--- modules/xalloc |1 + 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Cha

[PATCH 19/19] * top/maint.mk: Adjust to new noreturn support.

(gl_extract_significant_defines_): Omit pattern ATTRIBUTE_NORETURN. (def_sym_regex): Do not remove ATTRIBUTE_NORETURN. --- ChangeLog|4 top/maint.mk |3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 08f011c..42a4649 100644 --- a/Cha

[PATCH 07/19] argmatch-tests: use _Noreturn

* tests/test-argmatch.c (_GL_ATTRIBUTE_NORETURN): Remove. (ARGMATCH_DIE_DECL): Use _Noreturn instead. --- ChangeLog |4 tests/test-argmatch.c |8 +--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 12bffcb..8b5d79d 100644 ---

[PATCH 08/19] exclude-tests: use _Noreturn

* tests/test-exclude.c (_GL_ATTRIBUTE_NORETURN): Remove. (ARGMATCH_DIE_DECL): Use _Noreturn instead. --- ChangeLog|5 +++-- tests/test-exclude.c |8 +--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8b5d79d..b1fb51b 100644 --- a

[PATCH 16/19] xmemdup0: use stdnoreturn.h

* lib/xmemdup0.h: Include . (_GL_ATTRIBUTE_NORETURN): Remove; all uses replaced with noreturn. * modules/xmemdup0 (Depends-on): Add stdnoreturn. --- ChangeLog|5 + lib/xmemdup0.h |9 ++--- modules/xmemdup0 |1 + 3 files changed, 8 insertions(+), 7 deletions(-) diff -

[PATCH 15/19] sigpipe-die: use stdnoreturn.h

* lib/sigpipe-die.h: Include . (_GL_ATTRIBUTE_NORETURN): Remove; all uses replaced with noreturn. * modules/sigpipe-die (Depends-on): Add stdnoreturn. --- ChangeLog |5 + lib/sigpipe-die.h |9 ++--- modules/sigpipe-die |1 + 3 files changed, 8 insertions(+), 7 delet

[PATCH 13/19] * lib/openat-die.c (openat_save_fail): Modernize comment.

--- ChangeLog|2 ++ lib/openat-die.c |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index c16d917..fff4c98 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2011-07-10 Paul Eggert + * lib/openat-die.c (openat_save_fail):

[PATCH 12/19] * lib/xalloc-die.c (xalloc_die): Modernize comment.

--- ChangeLog|2 ++ lib/xalloc-die.c |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 47a5313..c16d917 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2011-07-10 Paul Eggert + * lib/xalloc-die.c (xalloc_die): Moder

[PATCH 11/19] * lib/glthread/thread.h: Modernize comment.

--- ChangeLog |2 ++ lib/glthread/thread.h |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1c91c98..47a5313 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,7 @@ 2011-07-10 Paul Eggert + * lib/glthread/thread.h: Mod

[PATCH 10/19] obstack: use _Noreturn

* lib/obstack.c (__attribute__): Remove macro. (print_and_abort): Use _Noreturn. --- ChangeLog |4 lib/obstack.c | 10 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index 83677cd..1c91c98 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,

[PATCH 09/19] c-stack: use _Noreturn

* lib/c-stack.c (die, overflow_handler, segv_handler): Use _Noreturn rather than __attribute__((noreturn)). --- ChangeLog |4 lib/c-stack.c | 10 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index b1fb51b..83677cd 100644 --- a/Chang

[PATCH 06/19] stdlib: use _Noreturn

* lib/stdlib.in.h (_GL_ATTRIBUTE_NORETURN): Remove. (_Exit): Use _Noreturn rather than _GL_ATTRIBUTE_NORETURN. * modules/stdlib (Depends-on): Add _Noreturn. (stdlib.h): Depend on $(_NORETURN_H), and copy it in. --- ChangeLog |6 ++ lib/stdlib.in.h |8 ++-- modules/stdlib |

[PATCH 05/19] stdnoreturn-tests: new module

* modules/stdnoreturn-tests, tests/test-stdnoreturn.c: New files. --- ChangeLog |3 +++ modules/stdnoreturn-tests | 11 +++ tests/test-stdnoreturn.c |2 ++ 3 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 modules/stdnoreturn-tests create mod

[PATCH 04/19] stdnoreturn: new module

* MODULES.html.sh (Noreturn ): New section. * m4/stdnoreturn.m4, modules/stdnoreturn: New files. --- ChangeLog |4 MODULES.html.sh | 10 ++ m4/stdnoreturn.m4 | 22 ++ modules/stdnoreturn | 34 ++ 4 files cha

[PATCH 03/19] _Noreturn-tests: new module

* modules/_Noreturn-tests, tests/test-_Noreturn.c: New files. --- ChangeLog |3 ++ modules/_Noreturn-tests | 10 + tests/test-_Noreturn.c | 52 +++ 3 files changed, 65 insertions(+), 0 deletions(-) create mode 100644 modul

[PATCH 02/19] _Noreturn: new module

* MODULES.html.sh (Support for systems lacking draft ISO C 1X): New section, mentioning it. * build-aux/_Noreturn.h, modules/_Noreturn: New files. --- ChangeLog |5 + MODULES.html.sh | 20 build-aux/_Noreturn.h |8 modules/_Noreturn

[PATCH 01/19] * m4/gnulib-common.m4 (gl_COMMON_BODY): Add _Noreturn.

This is the first of a proposed series of patches to: (1) add support for the draft C1X _Noreturn keyword, (2) add support for the draft C1X include, and (3) have the rest of gnulib use (1) and (2) Comments (as usual) are welcome. --- ChangeLog |4 m4/gnulib-common.m4 | 13

Re: Moving (initially function) attribute macros into a separate gnulib module

A couple of things. First, I have in mind something different for _GL_ATTRIBUTE_NORETURN, since _Noreturn is in draft C1X. I'll send out some proposed patches for this shortly. Second, don't you need to do something different for the *.in.h files, such as lib/string.in.h? They can't include gnu

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

>> Can you do "#pragma GCC diagnostic push" > I'll try it next week. It's not documented in the GCC-4.4 Texinfo > manual, though; perhaps it's a recent introduction. Yes, it's introduced in GCC 4.6.0. http://gcc.gnu.org/gcc-4.6/changes.html Presumably one can use it if available, and fall back

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

On Mon, Jul 11, 2011 at 1:11 AM, Paul Eggert wrote: > On 07/10/11 02:16, James Youngman wrote: >> A function-level pragma would probably be ideal here, but >> unfortunately they can only be used to tweak optimisation and function >> attributes. > > Can you do "#pragma GCC diagnostic push" at the s

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

On 07/10/11 02:16, James Youngman wrote: > A function-level pragma would probably be ideal here, but > unfortunately they can only be used to tweak optimisation and function > attributes. Can you do "#pragma GCC diagnostic push" at the start of the function, and "#pragma GCC diagnostic pop" at the

Re: Moving (initially function) attribute macros into a separate gnulib module

On 10/07/11 10:56, James Youngman wrote: > I just went to use some function attributes in findutils and noticed > that information about which versions of GCC support various > attributes is spread throughout gnulib. While a number of headers > define convenience macros (usually starting _GL_ATTRI

Moving (initially function) attribute macros into a separate gnulib module

I just went to use some function attributes in findutils and noticed that information about which versions of GCC support various attributes is spread throughout gnulib. While a number of headers define convenience macros (usually starting _GL_ATTRIBUTE_) there are a couple of naming inconsistenci

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

I ran into this issue as well some time ago, and my "solution" was to remove those definitions from my local gettext.h copy. It is a non-solution, but I thought I should mention it in case your project (like gsasl) does not use those gettext.h functions and you just want to silence the warning. h

Re: Correct but unhelpful VLA warning vs. gnulib's gettext.h; can we eliminate the false positive?

On Sun, Jul 10, 2011 at 5:47 AM, Paul Eggert wrote: > On 07/09/11 15:32, James Youngman wrote: >> Is there a way of eliminating this false positive which doesn't force >> me to give up -Wvla? > > You can use a pragma in the module that you've audited. > The pragma would tell GCC, "don't waste my t