[PATCH] maint.mk: enhance useless header checks

2011-06-24 Thread Eric Blake
Libvirt was mistakenly using instead of "intprops.h" in one place; when I fixed that, I was surprised to get a syntax-check failure from an unused header. * top/maint.mk (_sc_header_without_use): Check both include styles. (sc_prohibit_assert_without_use) (sc_prohibit_close_stream_without_use) (s

Re: [PATCH] maint.mk: update sc_prohibit_intprops_without_use

2011-06-24 Thread Jim Meyering
Eric Blake wrote: > This syntax check needs to reflect commit 8cc0fee and following. > > * top/maint.mk (_intprops_names): Match recent changes. > > Signed-off-by: Eric Blake > --- > > I found this by accident when 'make syntax-check' started failing > on libvirt due to a single use of INT_MULTIPL

[PATCH] maint.mk: update sc_prohibit_intprops_without_use

2011-06-24 Thread Eric Blake
This syntax check needs to reflect commit 8cc0fee and following. * top/maint.mk (_intprops_names): Match recent changes. Signed-off-by: Eric Blake --- I found this by accident when 'make syntax-check' started failing on libvirt due to a single use of INT_MULTIPLY_OVERFLOW. ChangeLog|5

Re: [PATCH 1/2] strerror_r: fix OpenBSD behavior on 0

2011-06-24 Thread Bruno Haible
Eric Blake wrote: > --- a/lib/strerror-override.c > +++ b/lib/strerror-override.c > @@ -37,6 +37,11 @@ strerror_override (int errnum) >    /* These error messages are taken from glibc/sysdeps/gnu/errlist.c.  */ >    switch (errnum) >      { > +#if REPLACE_STRERROR_0 > +    case 0: > +      return "

Re: PATH_MAX constant expression

2011-06-24 Thread Jim Meyering
Bruno Haible wrote: >> Bruno's comment (in the text you elided) suggests intent to have >> pathmax.h leave PATH_MAX undefined on the Hurd: >> >> >> I find it reasonable to use "#ifdef PATH_MAX" in front of every use of >> >> PATH_MAX, like POSIX requires. >> >> With such a change, each of the a