Re: [PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX]

2011-06-22 Thread Eric Blake
On 06/22/2011 04:21 PM, Paul Eggert wrote: > On 06/22/11 14:53, Eric Blake wrote: >> That's where the joy of per-file exceptions is handy > > Fine, but if I look at (say) Emacs, all six instances > of "[PATH_MAX" are fine. This particular syntax check > may be more trouble than it's worth. It's

Re: [PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX]

2011-06-22 Thread Paul Eggert
On 06/22/11 14:53, Eric Blake wrote: > That's where the joy of per-file exceptions is handy Fine, but if I look at (say) Emacs, all six instances of "[PATH_MAX" are fine. This particular syntax check may be more trouble than it's worth.

Re: [PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX]

2011-06-22 Thread Eric Blake
On 06/22/2011 03:49 PM, Paul Eggert wrote: > On 06/22/11 14:10, Eric Blake wrote: >> +@prohibit='\[PATH''_MAX' > > Doesn't this go too far? For example, gnulib's lib/stat.c does this: > > /* Due to mingw's oddities, ... > Fortunately, mingw PATH_MAX is small enough for stack >

Re: [PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX]

2011-06-22 Thread Paul Eggert
On 06/22/11 14:10, Eric Blake wrote: > + @prohibit='\[PATH''_MAX' Doesn't this go too far? For example, gnulib's lib/stat.c does this: /* Due to mingw's oddities, ... Fortunately, mingw PATH_MAX is small enough for stack allocation. */ char fixed_name[PATH_MAX

[PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX]

2011-06-22 Thread Eric Blake
POSIX allows PATH_MAX to be undefined. And even if you use the gnulib pathmax module, where "pathmax.h" guarantees a definition, the definition might not be constant or might be so large as to be wasteful or cause stack overflows. PATH_MAX should only be used as a limit or hueristic, not an array

[PATCH] link: work around IRIX bug

2011-06-22 Thread Eric Blake
On IRIX 6.5, link(file, "dangling") creates the target of dangling as a link to file, rather than failing with EEXIST. * m4/link.m4 (gl_FUNC_LINK): Expose the bug. * lib/link.c (rpl_link): Work around it. * tests/test-link.h (test_link): Enhance test. * doc/posix-functions/link.texi (link): Docume

Re: Static code analyzer Clang reports possible bug in getopt.c while developing gnu-pdf

2011-06-22 Thread Eric Blake
On 06/22/2011 10:30 AM, Eric Blake wrote: > Thanks for the report. I believe you (well, clang) found an actual > glibc bug! Of course, no one in their right mind ever calls > getopt(argc, argv, "W;"), do they? > > I'm in the process of seeing if I can quickly turn this into an actual > crashing

Re: Static code analyzer Clang reports possible bug in getopt.c while developing gnu-pdf

2011-06-22 Thread Eric Blake
On 06/22/2011 10:07 AM, Gustavo Martin Domato wrote: > Hi: > > I copy something I wrote on gnu-pdf development mailing list. Static > code analyzer Clang detected a possible bug at line 852. The file > they're using is a copy of the source. To see the report go to > http://www.gnupdf.org/prmgt/cla

Static code analyzer Clang reports possible bug in getopt.c while developing gnu-pdf

2011-06-22 Thread Gustavo Martin Domato
Hi: I copy something I wrote on gnu-pdf development mailing list. Static code analyzer Clang detected a possible bug at line 852. The file they're using is a copy of the source. To see the report go to http://www.gnupdf.org/prmgt/clang/report-kFVhsy.html#EndPath "> lib/getopt.c line 852 - This o

Re: test-linkat failure on IRIX

2011-06-22 Thread Eric Blake
On 06/20/2011 04:13 PM, Eric Blake wrote: > On 06/19/2011 08:48 AM, Bruno Haible wrote: >>> IRIX 6.5: >>> >>> test-linkat.c:234: assertion failed >>> ksh[10]: 1760562 Abort(coredump) >>> FAIL: test-linkat >> >> It fails here: >> >> /* AT_SYMLINK_FOLLOW only follows first argument, not second. */