Re: bug#8881: config.h double inclusion

2011-06-17 Thread Jack Kelly
On Fri, Jun 17, 2011 at 6:29 AM, Paul Eggert wrote: > On 06/16/11 10:36, Alfred M. Szmidt wrote: >> I'm thinking that maybe should be generated with a double >> inclusion guard > > But the general rule is that must always be included first, no? > So there shouldn't ever be a possibility of inclu

pwrite warnings

2011-06-17 Thread Bruno Haible
On AIX 6.1 and 7.1, with cc, I'm seeing warnings like this: "./../gllib/unistd.h", line 1411.12: 1506-236 (W) Macro name pwrite has been redefined. "./../gllib/unistd.h", line 1411.12: 1506-358 (I) "pwrite" is defined on line 965 of /usr/include/unistd.h. The reason is that pwrite is #defined t

Re: config.h double inclusion

2011-06-17 Thread Bruno Haible
Alfred M. Szmidt wrote: > > > I think that autoconf should have the guard for double inclusion. > > > > Autoconf does not need to provide a double-inclusion guard for > > config.h, because those packages that need it can get it through > > use of AH_TOP and AH_BOTTOM. > > That is not a rea

Re: config.h double inclusion

2011-06-17 Thread Alfred M. Szmidt
> I think that autoconf should have the guard for double inclusion. Autoconf does not need to provide a double-inclusion guard for config.h, because those packages that need it can get it through use of AH_TOP and AH_BOTTOM. That is not a reason to not include such a guard.

Re: spawn-pipe tests on OSF/1

2011-06-17 Thread Bruno Haible
Tom G. Christensen wrote: > With this change there is still a link failure on CentOS 5.6: > gcc -std=gnu99 -g -O2 -Wall -o test-spawn-pipe-child > test-spawn-pipe-child.o -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm > test-spawn-pipe-child.o: In function `main': > /home/tgc/projects/gnulib/buil

Re: spawn-pipe tests on OSF/1

2011-06-17 Thread Tom G. Christensen
On 06/17/2011 01:45 PM, Bruno Haible wrote: On 2011-06-06 I wrote: spawn-pipe tests: Like the child program only against libc. 2011-06-17 Bruno Haible spawn-pipe tests: Fix link error. * tests/test-spawn-pipe-child.c: Undefine fflush. With this change there is still

Re: Dealing with character ranges in grep

2011-06-17 Thread Jim Meyering
Johannes Meixner wrote: > Hello Jim, > > On Jun 16 10:44 Jim Meyering wrote (excerpt): Thus, if we go this route, we are effectively saying that people who want self-consistent regex-handling in our tools must build with --with-included-regex or end up causing subtle problems. >

clock_getcpuclockid versus clock-time

2011-06-17 Thread Andy Wingo
Hello gnulibbers, I have a curious issue. I would like to use clock_gettime with CLOCK_PROCESS_CPUTIME_ID. clock_gettime(2) notes some portability issues with this timer, suggesting that the user call clock_getcpuclockid(0) to verify that the timer is available. I was using the clock-time modul

Re: Dealing with character ranges in grep

2011-06-17 Thread Johannes Meixner
Hello Jim, On Jun 16 10:44 Jim Meyering wrote (excerpt): Thus, if we go this route, we are effectively saying that people who want self-consistent regex-handling in our tools must build with --with-included-regex or end up causing subtle problems. ... It goes like this (at least for gawk, gre

tests: remove unnecessary dependency

2011-06-17 Thread Bruno Haible
The following test files don't include "progname.h" although their module description asks for the 'progname' module. tests/test-canonicalize.c tests/test-chown.c tests/test-dirname.c tests/test-fdopendir.c tests/test-fdutimensat.c tests/test-hash.c tests/test-lchown.c tests/test-linkat.c tests/te

fix tests link errors

2011-06-17 Thread Bruno Haible
The test with --create-megatestdir gave a couple of link errors, that can be reproduced by testing a single module: $ ./gnulib-tool --test --with-tests ceil-ieee ... gcc -g -O2 -o test-ceil-ieee test-ceil-ieee.o ../gllib/libgnu.a @FLOOR_LIBM@ gcc: @FLOOR_LIBM@: No such file or directory make[

Re: spawn-pipe tests on OSF/1

2011-06-17 Thread Bruno Haible
On 2011-06-06 I wrote: > spawn-pipe tests: Like the child program only against libc. One link failure is still present: gcc -g -O2 -o test-spawn-pipe-child test-spawn-pipe-child.o test-spawn-pipe-child.o: In function `main': /tmp/testdir/gltests/test-spawn-pipe-child.c:86: undefined re