On 05/21/11 02:02, Andy Wingo wrote:
> On Wed 04 May 2011 18:36, Paul Eggert writes:
>
>> On 05/04/11 09:34, Andy Wingo wrote:
>>> Would you all be OK with making "clock-time" to be LGPL?
>>
>> Yes, that one's trivial: it actually contains only BSD-like license code
>> so it could be marked BSD-l
On 05/21/2011 10:15 AM, Eric Blake wrote:
> Avoid cygwin strerror_r, since it clobbers strerror buffer through
> cygwin 1.7.9. __xpg_strerror_r is okay, but if a program is
> compiled on cygwin 1.7.8 or earlier, it is not available.
Aargh. __xpg_strerror_r is _not_ okay, until the upcoming cygwi
On 05/21/2011 12:27 PM, Bruno Haible wrote:
> Eric Blake wrote:
>> Avoid cygwin strerror_r, since it clobbers strerror buffer through
>> cygwin 1.7.9. __xpg_strerror_r is okay, but if a program is
>> compiled on cygwin 1.7.8 or earlier, it is not available.
>>
>> * lib/strerror_r.c (strerror_r): D
The relocatable-prog-wrapper module compiles some source files to a
launcher program on the fly. When it does this, it requires some definitions
to be present in config.h, stdlib.h, and so on. This is the purpose of the
gl_FUNC_*_SEPARATE macro.
The comment for gl_FUNC_SETENV_SEPARATE says
Like
The platforms which have no strerror() are no longer among gnulib's
portability targets. So it's OK to assume strerror() exists, and the 'strerror'
module in its current form is overkill for relocwrapper.c.
2011-05-21 Bruno Haible
relocatable-prog-wrapper: Assume strerror() exists.
I'm applying this obvious code simplification:
2011-05-21 Bruno Haible
select: Simplify replacement idiom.
* m4/select.m4 (gl_FUNC_SELECT): Set REPLACE_SELECT also on native
Win32 platforms.
* lib/sys_select.in.h (select): Simplify accordingly.
* module
Eric Blake wrote:
> Avoid cygwin strerror_r, since it clobbers strerror buffer through
> cygwin 1.7.9. __xpg_strerror_r is okay, but if a program is
> compiled on cygwin 1.7.8 or earlier, it is not available.
>
> * lib/strerror_r.c (strerror_r): Don't use cygwin's strerror_r;
> fall back instead
Eric Blake wrote:
> 2011-05-20 Eric Blake
>
> + strerror_r: enforce POSIX recommendations
> + * lib/strerror_r.c (safe_copy): New helper method.
> + (strerror_r): Guarantee a non-empty string.
> + * tests/test-strerror_r.c (main): Enhance tests to incorporate
> + recent POS
Eric Blake wrote:
> @@ -48,7 +48,6 @@ AC_DEFUN([gl_FUNC_STRERROR_R],
> [AC_LANG_PROGRAM(
> [[#include
> #include
> - int strerror_r (int, char *, size_t);
> ]],
> [[int result = 0;
>
Hi Eric,
> > since the caller does not know
> > in advance how long the string will be (i.e. how long the buffer needs
> > to be for a complete message), that ERANGE should be the "lowest priority"
> > error. That is, I think EINVAL should take precedence over ERANGE.
>
> I personally disagree -
Hi Eric,
> > I would find these enhancements to the strerror_r specification useful
> > as well. But I would wait before changing gnulib until the issue has been
> > discussed in the Austin group and glibc has followed suit. If they start
> > to disagree, it's too early for gnulib to provide the m
Bruno Haible wrote:
> Hi Paul, Jim,
>
> The requirements of lib/dirchownmod.c are already fulfilled through the
> module description, which depends on 'lchmod' and 'lchown'. Here's a
> proposed simplification:
True. Good change. That's obviously correct.
Thank you.
> 2011-05-21 Bruno Haible
I'm fixing a posteriori a few syntactically incorrect (or at least unusual)
ChangeLog entries:
--- ChangeLog.orig Sat May 21 18:53:06 2011
+++ ChangeLog Sat May 21 18:52:50 2011
@@ -56,7 +56,7 @@
* tests/test-perror2.c (main): Enhance test.
test-perror: check for strerror
Avoid cygwin strerror_r, since it clobbers strerror buffer through
cygwin 1.7.9. __xpg_strerror_r is okay, but if a program is
compiled on cygwin 1.7.8 or earlier, it is not available.
* lib/strerror_r.c (strerror_r): Don't use cygwin's strerror_r;
fall back instead to sys_errlist.
* modules/stre
For historical reasons, the mkdtemp module was using a 'gt_' prefix.
2011-05-21 Bruno Haible
mkdtemp: Use gnulib naming conventions.
* m4/mkdtemp.m4 (gl_FUNC_MKDTEMP): Renamed from gt_FUNC_MKDTEMP.
* modules/mkdtemp (configure.ac): Update.
--- m4/mkdtemp.m4.orig Sat
Hi Eric,
I see nothing in m4/linkat.c that requires prior use of gl_FUNC_LINK.
The dependency from 'linkat' to 'link' is a normal module dependency.
Objections to this patch?
2011-05-21 Bruno Haible
linkat: Simplify autoconf macro.
* m4/linkat.m4 (gl_FUNC_LINKAT): Don't requi
Hi Eric,
Here's a proposed patch to update the dependencies of the modules 'linkat'
and 'renameat' to match the source code.
- at-func2.c includes "dosname.h" and "save-cwd.h".
- I don't see calls to readlink(), stpcpy(), symlinkat() there.
2011-05-21 Bruno Haible
linkat, rename
Hi Paul, Jim,
The requirements of lib/dirchownmod.c are already fulfilled through the
module description, which depends on 'lchmod' and 'lchown'. Here's a
proposed simplification:
2011-05-21 Bruno Haible
mkdir-p: Simplify autoconf macro.
* m4/mkdir-p.m4 (gl_MKDIR_PARENTS): Do
On Wed 04 May 2011 18:36, Paul Eggert writes:
> On 05/04/11 09:34, Andy Wingo wrote:
>> Would you all be OK with making "clock-time" to be LGPL?
>
> Yes, that one's trivial: it actually contains only BSD-like license code
> so it could be marked BSD-like if gnulib had a mark for that.
Ping :)
A
19 matches
Mail list logo
