Re: [PATCH 2/2] Add a test for glibc's Bugzilla bug #12378.

2011-05-13 Thread Eric Blake
On 05/12/2011 03:14 PM, James Youngman wrote: > From: James Youngman > > * m4/fnmatch.m4: Use gnulib's fnmatch if the system fnmatch > doesn't allow the literal matching of a lone "[" (which is > required by POSIX). > * tests/test-fnmatch.c (main): Check that "[/b" matches itself. Now pushed. -

[PATCH] getcwd-lgpl: relax test for FreeBSD

2011-05-13 Thread Eric Blake
getcwd(NULL, 1) mallocs a larger buffer on BSD, rather than failing with ERANGE as on glibc. This behavior difference is not worth coding around, as it is an uncommon use of getcwd in the first place. * doc/posix-functions/getcwd.texi (getcwd): Document portability issue. * tests/test-getcwd-lgpl

Re: test-getcwd-lgpl fails on FreeBSD 8.1

2011-05-13 Thread Eric Blake
On 05/13/2011 02:26 AM, Matthias Bolte wrote: > I found this while testing current libvirt git on FreeBSD 8.1 32bit. > > When running gmake check in the libvirt source tree then ASSERT > (getcwd (NULL, i) == NULL) in test-getcwd-lgpl.c in line 74 fails on > the first iteration of the for loop. Th

Re: [Bug-tar] interix timestamp issues

2011-05-13 Thread Eric Blake
On 05/13/2011 07:07 AM, Markus Duft wrote: > On 05/13/11 08:27, Paul Eggert wrote: >> On 05/12/11 23:15, Markus Duft wrote: >>> maybe i could even implement a futimes by memorizing the timestamps and >>> re-setting them after closing the file... Of course, you should not reset timestamps if some

Re: [Bug-tar] interix timestamp issues

2011-05-13 Thread Markus Duft
On 05/13/11 08:27, Paul Eggert wrote: > On 05/12/11 23:15, Markus Duft wrote: >> maybe i could even implement a futimes by memorizing the timestamps and >> re-setting them after closing the file... >> >> would that be better than hacking around in gnulib? libsuacomp is required >> anyway to get a

test-getcwd-lgpl fails on FreeBSD 8.1

2011-05-13 Thread Matthias Bolte
I found this while testing current libvirt git on FreeBSD 8.1 32bit. When running gmake check in the libvirt source tree then ASSERT (getcwd (NULL, i) == NULL) in test-getcwd-lgpl.c in line 74 fails on the first iteration of the for loop. When runnig in gdb ./gnulib/tests/test-getcwd-lgpl in the l